You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2016/01/11 23:32:47 UTC
Re: Review Request 39782: Add a comment for os::libraries::setPaths.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39782/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 10:32 p.m.)
Review request for mesos, Benjamin Bannier, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Rebase onto master.
Bugs: MESOS-3725
https://issues.apache.org/jira/browse/MESOS-3725
Repository: mesos
Description
-------
Add a comment for os::libraries::setPaths.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 14fbca6d222bdfc0e8be301050b4ea1a8a6e7758
Diff: https://reviews.apache.org/r/39782/diff/
Testing
-------
No code changes.
Thanks,
James Peach
Re: Review Request 39782: Add a comment for os::libraries::setPaths.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39782/#review114193
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Jan. 12, 2016, 10:14 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39782/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 10:14 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-3725
> https://issues.apache.org/jira/browse/MESOS-3725
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add a comment for os::libraries::setPaths.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 14fbca6d222bdfc0e8be301050b4ea1a8a6e7758
>
> Diff: https://reviews.apache.org/r/39782/diff/
>
>
> Testing
> -------
>
> No code changes.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 39782: Add a comment for os::libraries::setPaths.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39782/#review116466
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line 288)
<https://reviews.apache.org/r/39782/#comment177490>
Nit-pick: Replace `Setting ... . Neither` with `This has an effect only for child processes launched after calling setPaths; neither`.
- Benjamin Bannier
On Jan. 26, 2016, 8:24 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39782/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 8:24 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-3725
> https://issues.apache.org/jira/browse/MESOS-3725
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add a comment for os::libraries::setPaths.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ed3bb2c5ab035d8c0bbf9f44baa2b0b8fb1f79b6
>
> Diff: https://reviews.apache.org/r/39782/diff/
>
>
> Testing
> -------
>
> No code changes.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 39782: Add a comment for os::libraries::setPaths.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39782/
-----------------------------------------------------------
(Updated Feb. 4, 2016, 4:46 p.m.)
Review request for mesos, Benjamin Bannier, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Rebased onto master.
Bugs: MESOS-3725
https://issues.apache.org/jira/browse/MESOS-3725
Repository: mesos
Description
-------
Add a comment for os::libraries::setPaths.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 2eed65d2ed7ae8a6377646971bc6b1c252a65cbb
Diff: https://reviews.apache.org/r/39782/diff/
Testing
-------
No code changes.
Thanks,
James Peach
Re: Review Request 39782: Add a comment for os::libraries::setPaths.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39782/
-----------------------------------------------------------
(Updated Jan. 27, 2016, 6:44 p.m.)
Review request for mesos, Benjamin Bannier, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Updated.
Bugs: MESOS-3725
https://issues.apache.org/jira/browse/MESOS-3725
Repository: mesos
Description
-------
Add a comment for os::libraries::setPaths.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ed3bb2c5ab035d8c0bbf9f44baa2b0b8fb1f79b6
Diff: https://reviews.apache.org/r/39782/diff/
Testing
-------
No code changes.
Thanks,
James Peach
Re: Review Request 39782: Add a comment for os::libraries::setPaths.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39782/
-----------------------------------------------------------
(Updated Jan. 26, 2016, 7:24 p.m.)
Review request for mesos, Benjamin Bannier, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Rebased onto master.
Bugs: MESOS-3725
https://issues.apache.org/jira/browse/MESOS-3725
Repository: mesos
Description
-------
Add a comment for os::libraries::setPaths.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ed3bb2c5ab035d8c0bbf9f44baa2b0b8fb1f79b6
Diff: https://reviews.apache.org/r/39782/diff/
Testing
-------
No code changes.
Thanks,
James Peach
Re: Review Request 39782: Add a comment for os::libraries::setPaths.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39782/
-----------------------------------------------------------
(Updated Jan. 16, 2016, 12:45 a.m.)
Review request for mesos, Benjamin Bannier, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Rebased onto Master.
Bugs: MESOS-3725
https://issues.apache.org/jira/browse/MESOS-3725
Repository: mesos
Description
-------
Add a comment for os::libraries::setPaths.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 486a632bcccd24a7ceb5b5fdc58da5df269c4a21
Diff: https://reviews.apache.org/r/39782/diff/
Testing
-------
No code changes.
Thanks,
James Peach
Re: Review Request 39782: Add a comment for os::libraries::setPaths.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39782/
-----------------------------------------------------------
(Updated Jan. 12, 2016, 10:14 p.m.)
Review request for mesos, Benjamin Bannier, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Rebase onto master.
Bugs: MESOS-3725
https://issues.apache.org/jira/browse/MESOS-3725
Repository: mesos
Description
-------
Add a comment for os::libraries::setPaths.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 14fbca6d222bdfc0e8be301050b4ea1a8a6e7758
Diff: https://reviews.apache.org/r/39782/diff/
Testing
-------
No code changes.
Thanks,
James Peach