[GitHub] 1u0 commented on a change in pull request #7745: [FLINK-11632] Add new config option for TaskManager automatic address binding

[GitBox <gi...@apache.org>]

1u0 commented on a change in pull request #7745: [FLINK-11632] Add new config option for TaskManager automatic address binding
URL: https://github.com/apache/flink/pull/7745#discussion_r258397017
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
 ##########
 @@ -409,13 +409,30 @@ public static RpcService createRpcService(
 		if (taskManagerHostname != null) {
 			LOG.info("Using configured hostname/address for TaskManager: {}.", taskManagerHostname);
 		} else {
-			Time lookupTimeout = Time.milliseconds(AkkaUtils.getLookupTimeout(configuration).toMillis());
-
-			InetAddress taskManagerAddress = LeaderRetrievalUtils.findConnectingAddress(
-				haServices.getResourceManagerLeaderRetriever(),
-				lookupTimeout);
-
-			taskManagerHostname = taskManagerAddress.getHostName();
+			InetAddress taskManagerAddress;
 
 Review comment:
   @uce, the problem that with your approach, heuristic is still used and it won't be possible to validate if it's needed or not.
   One of the goals of FLINK-11632 is to explicitly separate the heuristic mechanism (in hope that it may be deprecated) and simpler alternative. Extending the heuristic to IP binding would make it harder to get rid of the heuristic mechanism, as it adds additional edge cases (also, there is no request for such feature, afaik).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services