[GitHub] [apisix] spacewander commented on a change in pull request #3493: feat: smooth weighted round-robin

[GitBox <gi...@apache.org>]

spacewander commented on a change in pull request #3493:
URL: https://github.com/apache/apisix/pull/3493#discussion_r569080828



##########
File path: apisix/schema_def.lua
##########
@@ -323,7 +323,7 @@ local upstream_schema = {
         type = {
             description = "algorithms of load balancing",
             type = "string",
-            enum = {"chash", "roundrobin", "ewma", "least_conn"}
+            enum = {"chash", "roundrobin", "ewma", "least_conn", "swrr"}

Review comment:
       This implementation is more fair when `(max weight - second max weight) / gcd` is large. 
   
   @redynasc 
   Maybe we need to put this as part of the original rr algorithm?
   We can choice this one if `(max weight - second max weight) / gcd > 5`.
   Thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org