[GitHub] [arrow-julia] complyue opened a new pull request #297: Solving #293

[GitBox <gi...@apache.org>]

complyue opened a new pull request #297:
URL: https://github.com/apache/arrow-julia/pull/297


   Implementing `Tables.partitions()` for `Arrow.Table` turns out trivial enough, though I'm not clear what to do about companion test cases, documentation etc.
   
   I'm lazy to have not excluded #296 from this PR, I'm open to draft another PR separated if you'd like, but the change set seems small, I hope you can have a quick look and decide what to do next.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-julia] complyue commented on pull request #297: Solving #293

[GitBox <gi...@apache.org>]

complyue commented on pull request #297:
URL: https://github.com/apache/arrow-julia/pull/297#issuecomment-1060315480


   With an alternative solution #298, changes from #296 are removed from this PR, now it's only about `Arrow.Table`'s `Tables.partitions()` implementation.
   
   I suggest the commit history should be squashed, but don't have experience how to do that from my side, only seeing articles suggesting "Squash and merge" option of Github, but that seems only doable when merging a PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org