You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by JoshRosen <gi...@git.apache.org> on 2014/08/29 00:01:34 UTC
[GitHub] spark pull request: [SPARK-3266] [Java] Change JavaRDDLike trait t...
GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/2186
[SPARK-3266] [Java] Change JavaRDDLike trait to abstract class.
JavaRDDLike's current design is a holdover from an earlier prototype that tried
to achieve code-reuse for methods like map(), filter(), etc. using the same
builder-trait pattern that the Scala collections library uses. This approach
didn't work due to some compiler issues, but unfortunately we never removed
the confusing trait implementation.
This patch changes JavaRDDLike from a trait to an abstract base class.
This should be source-compatible with earlier versions.
This change resolves some problems with certain inherited methods having the
wrong signatures in the bytecode (such as max(); see SPARK-3266).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JoshRosen/spark SPARK-3266
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2186.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2186
----
commit 492694bd03e93683b2cf79f7b9d64e33d395a586
Author: Josh Rosen <jo...@apache.org>
Date: 2014-08-28T21:52:46Z
[SPARK-3266] [Java] Change JavaRDDLike trait to abstract class.
JavaRDDLike's current design is a holdover from an earlier prototype that tried
to achieve code-reuse for methods like map(), filter(), etc. using the same
builder-trait pattern that the Scala collections library uses. This approach
didn't work due to some compiler issues, but unfortunately we never removed
the confusing trait implementation.
This patch changes JavaRDDLike from a trait to an abstract base class.
This should be source-compatible with earlier versions.
This change resolves some problems with certain inherited methods having the
wrong signatures in the bytecode (such as max(); see SPARK-3266).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3266] [Java] Change JavaRDDLike trait t...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2186#issuecomment-55970507
This almost certainly breaks binary compatibility; sorry for letting this PR sit for so long. I'll try to update it today or tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3266] [Java] Change JavaRDDLike trait t...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2186#issuecomment-53808727
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19431/consoleFull) for PR 2186 at commit [`492694b`](https://github.com/apache/spark/commit/492694bd03e93683b2cf79f7b9d64e33d395a586).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3266] [Java] Change JavaRDDLike trait t...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2186#issuecomment-53810025
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19431/consoleFull) for PR 2186 at commit [`492694b`](https://github.com/apache/spark/commit/492694bd03e93683b2cf79f7b9d64e33d395a586).
* This patch **fails** unit tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class JavaDoubleRDD(val srdd: RDD[scala.Double]) extends JavaRDDLike[JDouble] `
* `abstract class JavaRDDLike[T] extends Serializable `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3266] [Java] Change JavaRDDLike trait t...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2186#issuecomment-54695051
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19850/consoleFull) for PR 2186 at commit [`492694b`](https://github.com/apache/spark/commit/492694bd03e93683b2cf79f7b9d64e33d395a586).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3266] [Java] Change JavaRDDLike trait t...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen closed the pull request at:
https://github.com/apache/spark/pull/2186
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3266] [Java] Change JavaRDDLike trait t...
Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2186#issuecomment-55970035
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3266] [Java] Change JavaRDDLike trait t...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2186#issuecomment-54696015
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19850/consoleFull) for PR 2186 at commit [`492694b`](https://github.com/apache/spark/commit/492694bd03e93683b2cf79f7b9d64e33d395a586).
* This patch **fails** unit tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class JavaDoubleRDD(val srdd: RDD[scala.Double]) extends JavaRDDLike[JDouble] `
* `abstract class JavaRDDLike[T] extends Serializable `
* `case class AddJar(path: String) extends LeafNode with Command `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3266] [Java] Change JavaRDDLike trait t...
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2186#issuecomment-65168502
ping @JoshRosen, trying to decrease the number of open SQL PRs ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org