You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/04/10 15:58:00 UTC

Review Request 58306: Use Infra-Solr user to create Solr user-roles

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58306/
-----------------------------------------------------------

Review request for Ambari, Miklos Gergely, Robert Levas, and Sandor Magyari.


Bugs: AMBARI-20725
    https://issues.apache.org/jira/browse/AMBARI-20725


Repository: ambari


Description
-------

as infra-solr user exists where keytabs for infra solr is located, therefore we can use infra-solr users to run curl commands against solr servers. (also fixes issue, that kdestroy is not used for root user after kinit)


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py 1eeb86b 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 388aa57 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 0d38876 
  ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py ea3829e 


Diff: https://reviews.apache.org/r/58306/diff/1/


Testing
-------

in progress.. (manually)


Thanks,

Oliver Szabo


Re: Review Request 58306: Use Infra-Solr user to create Solr user-roles

Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58306/#review171450
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Levas


On April 10, 2017, 11:58 a.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58306/
> -----------------------------------------------------------
> 
> (Updated April 10, 2017, 11:58 a.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Levas, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-20725
>     https://issues.apache.org/jira/browse/AMBARI-20725
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> as infra-solr user exists where keytabs for infra solr is located, therefore we can use infra-solr users to run curl commands against solr servers. (also fixes issue, that kdestroy is not used for root user after kinit)
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py 1eeb86b 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 388aa57 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 0d38876 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py ea3829e 
> 
> 
> Diff: https://reviews.apache.org/r/58306/diff/1/
> 
> 
> Testing
> -------
> 
> in progress.. (manually)
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Re: Review Request 58306: Use Infra-Solr user to create Solr user-roles

Posted by Sandor Magyari <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58306/#review171468
-----------------------------------------------------------


Ship it!




Ship It!

- Sandor Magyari


On April 10, 2017, 3:58 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58306/
> -----------------------------------------------------------
> 
> (Updated April 10, 2017, 3:58 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Levas, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-20725
>     https://issues.apache.org/jira/browse/AMBARI-20725
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> as infra-solr user exists where keytabs for infra solr is located, therefore we can use infra-solr users to run curl commands against solr servers. (also fixes issue, that kdestroy is not used for root user after kinit)
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py 1eeb86b 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 388aa57 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 0d38876 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py ea3829e 
> 
> 
> Diff: https://reviews.apache.org/r/58306/diff/1/
> 
> 
> Testing
> -------
> 
> in progress.. (manually)
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Re: Review Request 58306: Use Infra-Solr user to create Solr user-roles

Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58306/#review171493
-----------------------------------------------------------


Ship it!




Ship It!

- Miklos Gergely


On April 10, 2017, 8:33 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58306/
> -----------------------------------------------------------
> 
> (Updated April 10, 2017, 8:33 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Levas, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-20725
>     https://issues.apache.org/jira/browse/AMBARI-20725
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> as infra-solr user exists where keytabs for infra solr is located, therefore we can use infra-solr users to run curl commands against solr servers. (also fixes issue, that kdestroy is not used for root user after kinit)
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py 1eeb86b 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 388aa57 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 0d38876 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py ea3829e 
> 
> 
> Diff: https://reviews.apache.org/r/58306/diff/1/
> 
> 
> Testing
> -------
> 
> done. (manually)
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Re: Review Request 58306: Use Infra-Solr user to create Solr user-roles

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58306/
-----------------------------------------------------------

(Updated April 10, 2017, 8:33 p.m.)


Review request for Ambari, Miklos Gergely, Robert Levas, and Sandor Magyari.


Changes
-------

manual testing done


Bugs: AMBARI-20725
    https://issues.apache.org/jira/browse/AMBARI-20725


Repository: ambari


Description
-------

as infra-solr user exists where keytabs for infra solr is located, therefore we can use infra-solr users to run curl commands against solr servers. (also fixes issue, that kdestroy is not used for root user after kinit)


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py 1eeb86b 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 388aa57 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 0d38876 
  ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py ea3829e 


Diff: https://reviews.apache.org/r/58306/diff/1/


Testing (updated)
-------

done. (manually)


Thanks,

Oliver Szabo