You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by gw...@apache.org on 2016/04/01 22:56:15 UTC
kafka git commit: MINOR: Fix BNF output for protocol arrays
conataining primitives in docs
Repository: kafka
Updated Branches:
refs/heads/trunk ae939467e -> b865413cd
MINOR: Fix BNF output for protocol arrays conataining primitives in docs
Before this patch arrays containing primitive types were not output:
```
Metadata Request (Version: 0) => [topics]
```
After this patch the type is listed:
```
Metadata Request (Version: 0) => [topics]
topics => STRING
```
Author: Grant Henke <gr...@gmail.com>
Reviewers: Ashish Singh, Gwen Shapira
Closes #1174 from granthenke/protocol-arrays
Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/b865413c
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/b865413c
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/b865413c
Branch: refs/heads/trunk
Commit: b865413cd8b71f905ad4ee695f193dcf91ee0595
Parents: ae93946
Author: Grant Henke <gr...@gmail.com>
Authored: Fri Apr 1 13:56:11 2016 -0700
Committer: Gwen Shapira <cs...@gmail.com>
Committed: Fri Apr 1 13:56:11 2016 -0700
----------------------------------------------------------------------
.../main/java/org/apache/kafka/common/protocol/Protocol.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kafka/blob/b865413c/clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java b/clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java
index 43110b5..475a4f2 100644
--- a/clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java
+++ b/clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java
@@ -792,13 +792,13 @@ public class Protocol {
b.append(field.name);
b.append("] ");
Type innerType = ((ArrayOf) field.type).type();
- if (innerType instanceof Schema && !subTypes.containsKey(field.name))
- subTypes.put(field.name, (Schema) innerType);
+ if (!subTypes.containsKey(field.name))
+ subTypes.put(field.name, innerType);
} else if (field.type instanceof Schema) {
b.append(field.name);
b.append(" ");
if (!subTypes.containsKey(field.name))
- subTypes.put(field.name, (Schema) field.type);
+ subTypes.put(field.name, field.type);
} else {
b.append(field.name);
b.append(" ");