You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2013/08/02 11:44:55 UTC
Review Request 13236: CLOUDSTACK: 3798: Fixed
test_accounts.TestUserLogin.test_LoginApiUuidResponse
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13236/
-----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam.
Repository: cloudstack-git
Description
-------
Removed wrong assert. It was checking if response is None, while it should check the reverse.
Sessionkey in response is checked below.
Test case running ok now.
Diffs
-----
test/integration/component/test_accounts.py 9c3d231
Diff: https://reviews.apache.org/r/13236/diff/
Testing
-------
Thanks,
Gaurav Aradhye
Re: Review Request 13236: CLOUDSTACK: 3798: Fixed
test_accounts.TestUserLogin.test_LoginApiUuidResponse
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13236/#review24515
-----------------------------------------------------------
The reason for failure of the login tests is that Marvin is not packaging the login/logout APIs as part of it. This needs to be fixed upstream in the marvin library generator.
- Prasanna Santhanam
On Aug. 2, 2013, 9:44 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13236/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2013, 9:44 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Removed wrong assert. It was checking if response is None, while it should check the reverse.
> Sessionkey in response is checked below.
>
> Test case running ok now.
>
>
> Diffs
> -----
>
> test/integration/component/test_accounts.py 9c3d231
>
> Diff: https://reviews.apache.org/r/13236/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 13236: CLOUDSTACK: 3798: Fixed
test_accounts.TestUserLogin.test_LoginApiUuidResponse
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13236/#review24522
-----------------------------------------------------------
Ship it!
The problem will be seen only when using marvin.sync to update marvin. The tarballs generated by the marvin build have the loginCMd in them. So this works with the tarball that the test infra uses.
- Prasanna Santhanam
On Aug. 2, 2013, 9:44 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13236/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2013, 9:44 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Removed wrong assert. It was checking if response is None, while it should check the reverse.
> Sessionkey in response is checked below.
>
> Test case running ok now.
>
>
> Diffs
> -----
>
> test/integration/component/test_accounts.py 9c3d231
>
> Diff: https://reviews.apache.org/r/13236/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>