You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/06 23:15:16 UTC
[GitHub] [druid] jon-wei opened a new pull request #9330: Allow overriding
default JoinableFactory in SpecificSegmentsQuerySegmentWalker
jon-wei opened a new pull request #9330: Allow overriding default JoinableFactory in SpecificSegmentsQuerySegmentWalker
URL: https://github.com/apache/druid/pull/9330
This PR adjusts SpecificSegmentsQuerySegmentWalker (used by tests and benchmarks) to allow the caller to provide their own JoinableFactory.
This is useful for tests/benchmarks where we are not using inline or lookup joins (such as on tables provided through https://github.com/apache/druid/pull/9279)
This PR has:
- [X] been self-reviewed.
- [X] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm merged pull request #9330: Allow overriding default
JoinableFactory in SpecificSegmentsQuerySegmentWalker
Posted by GitBox <gi...@apache.org>.
gianm merged pull request #9330: Allow overriding default JoinableFactory in SpecificSegmentsQuerySegmentWalker
URL: https://github.com/apache/druid/pull/9330
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org