You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/02/11 01:59:45 UTC
[GitHub] [activemq-nms-amqp] brudo opened a new pull request #63: NO-JIRA: Switch .NET Core targets from 2.2 (no longer supported) back to 2.1 (LTS)
brudo opened a new pull request #63:
URL: https://github.com/apache/activemq-nms-amqp/pull/63
_This pull request is not necessarily proposed to merge, but is more for discussion - and also for a test to see what Travis CI does with it._
As .NET Core 2.2 has reached end of life, I tried switching the references back to 2.1 which is still supported at this time (albeit only until August). This affects the test suite, the samples, and the CI config. The main output package, targeting .NET Standard 2.0, is unchanged. As far as I can tell, it didn't cause any problems building and testing locally.
It is noted that this PR is mutually exclusive with #49 which contemplates upgrading to .NET Core 3.0; but that 3.0 is also EOL. I would be happy with bumping that to 3.1, and seeing that merged in lieu of this PR - I don't usually target 2.1 anymore myself. However, there was discussion in that PR about preserving compatibility. So, while the present PR it does not take advantage of any new functionality in later versions of .NET, it does continue to test for backward compatibility, at least.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-nms-amqp] michaelandrepearce merged pull request #63: NO-JIRA: Switch .NET Core targets from 2.2 (no longer supported) back to 2.1 (LTS)
Posted by GitBox <gi...@apache.org>.
michaelandrepearce merged pull request #63:
URL: https://github.com/apache/activemq-nms-amqp/pull/63
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on pull request #63: NO-JIRA: Switch .NET Core targets from 2.2 (no longer supported) back to 2.1 (LTS)
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #63:
URL: https://github.com/apache/activemq-nms-amqp/pull/63#issuecomment-777435807
LGTM too @lukabsent - can you also patch this onto the 2.0 branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on pull request #63: NO-JIRA: Switch .NET Core targets from 2.2 (no longer supported) back to 2.1 (LTS)
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #63:
URL: https://github.com/apache/activemq-nms-amqp/pull/63#issuecomment-777603643
@brudo thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-nms-amqp] michaelandrepearce edited a comment on pull request #63: NO-JIRA: Switch .NET Core targets from 2.2 (no longer supported) back to 2.1 (LTS)
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on pull request #63:
URL: https://github.com/apache/activemq-nms-amqp/pull/63#issuecomment-777435807
LGTM too @lukeabsent - can you also patch this onto the 2.0 branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org