You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/12/09 23:53:49 UTC
Review Request 41156: Cleaned up formatting and employed a better
macro in authz tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41156/
-----------------------------------------------------------
Review request for mesos, Neil Conway and Till Toenshoff.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/tests/authorization_tests.cpp 32beeea3584f093bcac24e0c160235de0e3abb28
Diff: https://reviews.apache.org/r/41156/diff/
Testing
-------
`GTEST_FILTER="*AuthorizationTest*" make check -j7` on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
Re: Review Request 41156: Employed a better macro in tests,
cleaned up formatting.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41156/#review109742
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Dec. 9, 2015, 11:36 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41156/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 11:36 p.m.)
>
>
> Review request for mesos, Michael Park, Neil Conway, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced all instances of `AWAIT_EXPECT_EQ({true|false}, ...)` with more appropriate `AWAIT_EXPECT_{TRUE|FALSE}(...)`. Also wrapped typenames in backticks in "authorization_tests.cpp".
>
>
> Diffs
> -----
>
> src/tests/authorization_tests.cpp 32beeea3584f093bcac24e0c160235de0e3abb28
> src/tests/group_tests.cpp 9db6162dae0a2657e12f4e99334f9cab65d14e9a
>
> Diff: https://reviews.apache.org/r/41156/diff/
>
>
> Testing
> -------
>
> `GTEST_FILTER="*AuthorizationTest*:*GroupTest*" make check -j7` on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 41156: Employed a better macro in tests,
cleaned up formatting.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41156/#review109661
-----------------------------------------------------------
Bad patch!
Reviews applied: [41156]
Failed command: ./support/apply-review.sh -n -r 41156
Error:
2015-12-10 01:55:11 URL:https://reviews.apache.org/r/41156/diff/raw/ [14423/14423] -> "41156.patch" [1]
error: patch failed: src/tests/authorization_tests.cpp:390
error: src/tests/authorization_tests.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Dec. 9, 2015, 11:36 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41156/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 11:36 p.m.)
>
>
> Review request for mesos, Michael Park, Neil Conway, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced all instances of `AWAIT_EXPECT_EQ({true|false}, ...)` with more appropriate `AWAIT_EXPECT_{TRUE|FALSE}(...)`. Also wrapped typenames in backticks in "authorization_tests.cpp".
>
>
> Diffs
> -----
>
> src/tests/authorization_tests.cpp 32beeea3584f093bcac24e0c160235de0e3abb28
> src/tests/group_tests.cpp 9db6162dae0a2657e12f4e99334f9cab65d14e9a
>
> Diff: https://reviews.apache.org/r/41156/diff/
>
>
> Testing
> -------
>
> `GTEST_FILTER="*AuthorizationTest*:*GroupTest*" make check -j7` on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 41156: Employed a better macro in tests,
cleaned up formatting.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41156/
-----------------------------------------------------------
(Updated Dec. 9, 2015, 11:36 p.m.)
Review request for mesos, Michael Park, Neil Conway, and Till Toenshoff.
Changes
-------
Expanded the scope of the patch, updated summary and description, +MPark.
Summary (updated)
-----------------
Employed a better macro in tests, cleaned up formatting.
Repository: mesos
Description (updated)
-------
Replaced all instances of `AWAIT_EXPECT_EQ({true|false}, ...)` with more appropriate `AWAIT_EXPECT_{TRUE|FALSE}(...)`. Also wrapped typenames in backticks in "authorization_tests.cpp".
Diffs (updated)
-----
src/tests/authorization_tests.cpp 32beeea3584f093bcac24e0c160235de0e3abb28
src/tests/group_tests.cpp 9db6162dae0a2657e12f4e99334f9cab65d14e9a
Diff: https://reviews.apache.org/r/41156/diff/
Testing (updated)
-------
`GTEST_FILTER="*AuthorizationTest*:*GroupTest*" make check -j7` on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
Re: Review Request 41156: Cleaned up formatting and employed a better
macro in authz tests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Dec. 9, 2015, 10:58 p.m., Neil Conway wrote:
> > There are a few more instances of the `AWAIT_EXPECT_EQ(true, ...)` pattern in group_tests.cpp -- want to fix those as well?
I was looking at "authorization_tests.cpp", but... why not? Will do!
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41156/#review109622
-----------------------------------------------------------
On Dec. 9, 2015, 10:53 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41156/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 10:53 p.m.)
>
>
> Review request for mesos, Neil Conway and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/authorization_tests.cpp 32beeea3584f093bcac24e0c160235de0e3abb28
>
> Diff: https://reviews.apache.org/r/41156/diff/
>
>
> Testing
> -------
>
> `GTEST_FILTER="*AuthorizationTest*" make check -j7` on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 41156: Cleaned up formatting and employed a better
macro in authz tests.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41156/#review109622
-----------------------------------------------------------
Ship it!
There are a few more instances of the `AWAIT_EXPECT_EQ(true, ...)` pattern in group_tests.cpp -- want to fix those as well?
- Neil Conway
On Dec. 9, 2015, 10:53 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41156/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 10:53 p.m.)
>
>
> Review request for mesos, Neil Conway and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/authorization_tests.cpp 32beeea3584f093bcac24e0c160235de0e3abb28
>
> Diff: https://reviews.apache.org/r/41156/diff/
>
>
> Testing
> -------
>
> `GTEST_FILTER="*AuthorizationTest*" make check -j7` on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>