[GitHub] [hbase] huaxiangsun commented on a change in pull request #3495: HBASE-24984 WAL corruption due to early DBBs re-use when Durability.A…

[GitBox <gi...@apache.org>]

huaxiangsun commented on a change in pull request #3495:
URL: https://github.com/apache/hbase/pull/3495#discussion_r672393896



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerCall.java
##########
@@ -175,23 +178,17 @@ private void release(int mask) {
     }
   }
 
-  @Override
-  public void cleanup() {
-    release(0b01);
+  public void retainByWAL() {
+    reference.incrementAndGet();
   }
 
-  public void retainByWAL() {
-    for (;;) {
-      int ref = reference.get();
-      int nextRef = ref | 0b10;
-      if (reference.compareAndSet(ref, nextRef)) {
-        return;
+  public void releaseByWAL() {
+    if (reference.decrementAndGet() == 0) {

Review comment:
       I did some test to show the binary bits are set correctly.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org