You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Lars Hofhansl (JIRA)" <ji...@apache.org> on 2016/10/26 21:25:59 UTC
[jira] [Comment Edited] (HBASE-14465) Backport 'Allow rowlock to be
reader/write' to branch-1
[ https://issues.apache.org/jira/browse/HBASE-14465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609721#comment-15609721 ]
Lars Hofhansl edited comment on HBASE-14465 at 10/26/16 9:25 PM:
-----------------------------------------------------------------
This is a coprocessor accessible API, so I'd say that we shouldn't have changed it. I didn't review the change so I can't complain, but I would've -1'd based on this.
I'd also agree that coopting the same API to mean something _completely_ different is bad - the same boolean meaning taking a _readlock_ now instead of _waiting for a writelock_.
In any case, this is water under the bridge now. Let's at least fix the Java Doc. Anything else we can do now?
was (Author: lhofhansl):
This is a coprocessor accessible API, so I'd say that we shouldn't have changed it. I didn't review the change so I can't complain, but I would've -1'd based on this.
I'd also agree that coopting the same API mean something completely different is bad - the same boolean meaning taking a readlock now instead of waiting for a writelock.
In any case, this is water under the bridge now. Let's at least fix the Java Doc. Anything else we can do now?
> Backport 'Allow rowlock to be reader/write' to branch-1
> -------------------------------------------------------
>
> Key: HBASE-14465
> URL: https://issues.apache.org/jira/browse/HBASE-14465
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver
> Reporter: stack
> Assignee: stack
> Fix For: 1.2.0, 1.3.0
>
> Attachments: 14465.branch-1.txt, 14465.branch-1.v2.txt, 14465.branch-1.v2.txt, 14465.branch-1.v2.txt, 14465.branch-1.v3.txt, 14465.branch-1.v3.txt, 14465.branch-1.v4.txt, 14465.branch-1.v4.txt, 14465.branch-1.v4.txt, 14465.branch-1.v5.txt, 14465.branch-1.v5.txt, 14465.branch-1.v9.txt, 14465.branch-1.v9.txt, 14465.branch-1.v9.txt, 14465.txt
>
>
> Backport to branch-1.
> You want this in 1.2 [~busbey]? Its cleanup and fixes a possible dataloss. On other hand, its a bit of refactoring.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)