You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/27 21:04:36 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3996: UI: Hide
cpuspeed for custom constrained offering
ustcweizhou opened a new pull request #3996: UI: Hide cpuspeed for custom constrained offering
URL: https://github.com/apache/cloudstack/pull/3996
## Description
<!--- Describe your changes in detail -->
For customer constrained offering, the cpu speed is fixed.
Therefore the 'CpuSpeed' field should be hidden for customer constrained offering when change vm offering on UI.
It is visible only for unconstrained offering.
This is regression issue of #3245
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3996: UI: Hide cpuspeed for
custom constrained offering
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3996: UI: Hide cpuspeed for custom constrained offering
URL: https://github.com/apache/cloudstack/pull/3996#issuecomment-605844380
cc @shwstppr @DaanHoogland @andrijapanicsb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] shwstppr commented on issue #3996: UI: Hide cpuspeed
for custom constrained offering
Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #3996: UI: Hide cpuspeed for custom constrained offering
URL: https://github.com/apache/cloudstack/pull/3996#issuecomment-605917978
@ustcweizhou This is in vm deploy wizard?
I'm not able to reproduce any problem with 4.13 in UI.
CPU speed field is already hidden for Custom Constrained type offerings. Even after selecting an unconstrained offering then again selecting constrained offering. How to reproduce the problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3996: UI: Hide
cpuspeed for custom constrained offering
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3996: UI: Hide cpuspeed for custom constrained offering
URL: https://github.com/apache/cloudstack/pull/3996#issuecomment-606055486
> @ustcweizhou This is in vm deploy wizard?
> I'm not able to reproduce any problem with 4.13 in UI.
> CPU speed field is already hidden for Custom Constrained type offerings. Even after selecting an unconstrained offering then again selecting constrained offering. How to reproduce the problem?
@shwstppr as I mentioned in the description, this issue happens when change vm offering.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services