[GitHub] [rocketmq] mxsm commented on pull request #5592: [ISSUE #5584]Use non-synchronized getTimeZone

[GitBox <gi...@apache.org>]

mxsm commented on PR #5592:
URL: https://github.com/apache/rocketmq/pull/5592#issuecomment-1326507966

   ## Before
   ```
   # JMH version: 1.35
   # VM version: JDK 1.8.0_342, OpenJDK 64-Bit Server VM, 25.342-b07
   # VM invoker: /usr/lib/jvm/java-8-openjdk-amd64/jre/bin/java
   # VM options: <none>
   # Blackhole mode: full + dont-inline hint (auto-detected, use -Djmh.blackhole.autoDetect=false to disable)
   # Warmup: 3 iterations, 2 s each
   # Measurement: 3 iterations, 4 s each
   # Timeout: 10 min per iteration
   # Threads: 8 threads, will synchronize iterations
   # Benchmark mode: Throughput, ops/time
   # Benchmark: com.github.mxsm.TimeZoneBenchmark.timeZoneSynchronized
   
   # Run progress: 0.00% complete, ETA 00:00:18
   # Fork: 1 of 1
   # Warmup Iteration   1: 3355510.052 ops/s
   # Warmup Iteration   2: 3679662.938 ops/s
   # Warmup Iteration   3: 3838317.105 ops/s
   Iteration   1: 3850009.830 ops/s
                    ·stack: <delayed till summary>
   
   Iteration   2: 3777740.945 ops/s
                    ·stack: <delayed till summary>
   
   Iteration   3: 3705109.916 ops/s
                    ·stack: <delayed till summary>
   
   
   
   Result "com.github.mxsm.TimeZoneBenchmark.timeZoneSynchronized":
     3777620.230 ±(99.9%) 1321758.302 ops/s [Average]
     (min, avg, max) = (3705109.916, 3777620.230, 3850009.830), stdev = 72450.033
     CI (99.9%): [2455861.929, 5099378.532] (assumes normal distribution)
   
   Secondary result "com.github.mxsm.TimeZoneBenchmark.timeZoneSynchronized:·stack":
   Stack profiler:
   
   ....[Thread state distributions]....................................................................
    85.9%         BLOCKED
    13.8%         RUNNABLE
     0.2%         WAITING
   
   ....[Thread state: BLOCKED].........................................................................
    85.9% 100.0% java.util.TimeZone.getTimeZone
   
   ....[Thread state: RUNNABLE]........................................................................
    12.4%  89.3% java.util.TimeZone.getTimeZone
     0.7%   5.0% java.util.GregorianCalendar.computeFields
     0.2%   1.4% java.lang.Object.clone
     0.1%   0.6% java.util.Arrays.copyOf
     0.1%   0.5% java.text.SimpleDateFormat.format
     0.1%   0.5% sun.util.calendar.ZoneInfoFile.toCustomID
     0.1%   0.4% sun.util.calendar.ZoneInfo.getTransitionIndex
     0.1%   0.4% java.text.SimpleDateFormat.initialize
     0.0%   0.2% java.text.DateFormatSymbols.<init>
     0.0%   0.2% java.text.SimpleDateFormat.subFormat
     0.2%   1.5% <other>
   
   ....[Thread state: WAITING].........................................................................
     0.2% 100.0% sun.misc.Unsafe.park
   
   
   
   # Run complete. Total time: 00:00:18
   
   REMEMBER: The numbers below are just data. To gain reusable insights, you need to follow up on
   why the numbers are the way they are. Use profilers (see -prof, -lprof), design factorial
   experiments, perform baseline and negative tests that provide experimental control, make sure
   the benchmarking environment is safe on JVM/OS/HW level, ask for reviews from the domain experts.
   Do not assume the numbers tell you what you want them to tell.
   
   Benchmark                                       Mode  Cnt        Score         Error  Units
   TimeZoneBenchmark.timeZoneSynchronized         thrpt    3  3777620.230 ± 1321758.302  ops/s
   TimeZoneBenchmark.timeZoneSynchronized:·stack  thrpt               NaN                  ---
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org