You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2019/01/11 10:02:30 UTC
Review Request 69719: Exposed subscriptions and disconnections RP
manager metrics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69719/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao and James DeFelice.
Bugs: MESOS-9223
https://issues.apache.org/jira/browse/MESOS-9223
Repository: mesos
Description
-------
This patch adds monotonically increasing counters for subscriptions and
disconnections of resource providers with the resource provider manager
(`resource_provider_manager/subscriptions` and
`resource_provider_manager/disconnections`, respectively). While the
existing gauge `resource_provider_manager/subscribed` exposed the
current state, these added counters can be used to monitor resource
provider state for unexpected events.
Diffs
-----
src/resource_provider/manager.cpp 65852c629393f32fd582bfcff86d7ce14e5386ac
src/tests/resource_provider_manager_tests.cpp 20cfb340bf634354865d79c92ee70cddca08f28a
Diff: https://reviews.apache.org/r/69719/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69719: Exposed subscriptions and disconnections RP
manager metrics.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On Jan. 14, 2019, 11:55 p.m., Chun-Hung Hsiao wrote:
> > src/resource_provider/manager.cpp
> > Lines 823-832 (original), 827-836 (patched)
> > <https://reviews.apache.org/r/69719/diff/1/?file=2119190#file2119190line827>
> >
> > How about moving this snippt to the end of this function, so the agent would receive `SUBSCRIBE` and then `DISCONNECT` no matter if the RP has a connection problem after it subscribes? This would also make the metric reveal the connection problem.
>
> Benjamin Bannier wrote:
> This is supposed to be a counter for successful subscriptions, see below.
The problem I describe still remains. Moving the `return` statement around could help us to capture the disconnection in the metrics. WDYT?
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69719/#review211971
-----------------------------------------------------------
On Jan. 15, 2019, 9:27 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69719/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2019, 9:27 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and James DeFelice.
>
>
> Bugs: MESOS-9223
> https://issues.apache.org/jira/browse/MESOS-9223
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds monotonically increasing counters for subscriptions and
> disconnections of resource providers with the resource provider manager
> (`resource_provider_manager/subscriptions` and
> `resource_provider_manager/disconnections`, respectively). While the
> existing gauge `resource_provider_manager/subscribed` exposed the
> current state, these added counters can be used to monitor resource
> provider state for unexpected events.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 65852c629393f32fd582bfcff86d7ce14e5386ac
> src/tests/resource_provider_manager_tests.cpp 455ce7d2c71f2815430b69a5475b2ccc343cd9af
>
>
> Diff: https://reviews.apache.org/r/69719/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69719: Exposed subscriptions and disconnections RP
manager metrics.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On Jan. 14, 2019, 11:55 p.m., Chun-Hung Hsiao wrote:
> > src/resource_provider/manager.cpp
> > Lines 1004-1005 (patched)
> > <https://reviews.apache.org/r/69719/diff/1/?file=2119190#file2119190line1004>
> >
> > How about the following, to make it consistent with, e.g., `master/messages_register_framework`, and also make it less confusing w/ `resource_provider_manager/subscribed`?
> > ```
> > messages_subscribe("resource_provider_manager/messages_subscribe"),
> > messages_disconnect("resource_provider_manager/messages_disconnect")
> > ```
>
> Benjamin Bannier wrote:
> These are not really counters for messages as disconnections have no relation to messages the RP manager receives, and the subscriptions counter is supposed to count successfull connections (not just all subscription attempts (this allows correlating subscription and disconnection counters). What do you think about naming them e.g., `resource_provider_manager/events/[subscribe|disconnect]`? We could introduce a separate counter for subscription messages later.
Hmm I was actually thinking about the number of `ResourceProviderMessage` enqueued by the RP manager (and received by the agent actor). But yeah the names I suggested here are confusing, as you pointed out that one might think they're messages received by the RP manager. (I also confused myself with `master/messages_register_framework`.)
Not sure if `events` would make it better. I'm fine with keeping it as-is or go with `events` now. Dropping.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69719/#review211971
-----------------------------------------------------------
On Jan. 15, 2019, 9:27 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69719/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2019, 9:27 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and James DeFelice.
>
>
> Bugs: MESOS-9223
> https://issues.apache.org/jira/browse/MESOS-9223
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds monotonically increasing counters for subscriptions and
> disconnections of resource providers with the resource provider manager
> (`resource_provider_manager/subscriptions` and
> `resource_provider_manager/disconnections`, respectively). While the
> existing gauge `resource_provider_manager/subscribed` exposed the
> current state, these added counters can be used to monitor resource
> provider state for unexpected events.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 65852c629393f32fd582bfcff86d7ce14e5386ac
> src/tests/resource_provider_manager_tests.cpp 455ce7d2c71f2815430b69a5475b2ccc343cd9af
>
>
> Diff: https://reviews.apache.org/r/69719/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69719: Exposed subscriptions and disconnections RP
manager metrics.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Jan. 15, 2019, 12:55 a.m., Chun-Hung Hsiao wrote:
> > src/resource_provider/manager.cpp
> > Lines 823-832 (original), 827-836 (patched)
> > <https://reviews.apache.org/r/69719/diff/1/?file=2119190#file2119190line827>
> >
> > How about moving this snippt to the end of this function, so the agent would receive `SUBSCRIBE` and then `DISCONNECT` no matter if the RP has a connection problem after it subscribes? This would also make the metric reveal the connection problem.
>
> Benjamin Bannier wrote:
> This is supposed to be a counter for successful subscriptions, see below.
>
> Chun-Hung Hsiao wrote:
> The problem I describe still remains. Moving the `return` statement around could help us to capture the disconnection in the metrics. WDYT?
Makes sense, updated the patch.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69719/#review211971
-----------------------------------------------------------
On Jan. 16, 2019, 12:49 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69719/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2019, 12:49 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and James DeFelice.
>
>
> Bugs: MESOS-9223
> https://issues.apache.org/jira/browse/MESOS-9223
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds monotonically increasing counters for subscriptions and
> disconnections of resource providers with the resource provider manager
> (`resource_provider_manager/events/subscribed` and
> `resource_provider_manager/events/disconnects`, respectively). While the
> existing gauge `resource_provider_manager/subscribed` exposed the
> current state, these added counters can be used to monitor resource
> provider state for unexpected events.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 65852c629393f32fd582bfcff86d7ce14e5386ac
> src/tests/resource_provider_manager_tests.cpp 455ce7d2c71f2815430b69a5475b2ccc343cd9af
>
>
> Diff: https://reviews.apache.org/r/69719/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69719: Exposed subscriptions and disconnections RP
manager metrics.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Jan. 15, 2019, 12:55 a.m., Chun-Hung Hsiao wrote:
> > src/resource_provider/manager.cpp
> > Lines 823-832 (original), 827-836 (patched)
> > <https://reviews.apache.org/r/69719/diff/1/?file=2119190#file2119190line827>
> >
> > How about moving this snippt to the end of this function, so the agent would receive `SUBSCRIBE` and then `DISCONNECT` no matter if the RP has a connection problem after it subscribes? This would also make the metric reveal the connection problem.
This is supposed to be a counter for successful subscriptions, see below.
> On Jan. 15, 2019, 12:55 a.m., Chun-Hung Hsiao wrote:
> > src/resource_provider/manager.cpp
> > Lines 1004-1005 (patched)
> > <https://reviews.apache.org/r/69719/diff/1/?file=2119190#file2119190line1004>
> >
> > How about the following, to make it consistent with, e.g., `master/messages_register_framework`, and also make it less confusing w/ `resource_provider_manager/subscribed`?
> > ```
> > messages_subscribe("resource_provider_manager/messages_subscribe"),
> > messages_disconnect("resource_provider_manager/messages_disconnect")
> > ```
These are not really counters for messages as disconnections have no relation to messages the RP manager receives, and the subscriptions counter is supposed to count successfull connections (not just all subscription attempts (this allows correlating subscription and disconnection counters). What do you think about naming them e.g., `resource_provider_manager/events/[subscribe|disconnect]`? We could introduce a separate counter for subscription messages later.
> On Jan. 15, 2019, 12:55 a.m., Chun-Hung Hsiao wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Lines 1463-1468 (patched)
> > <https://reviews.apache.org/r/69719/diff/1/?file=2119191#file2119191line1463>
> >
> > We usually do the following instead:
> > ```
> > ASSERT_NE(0u, snapshot.values.count(...));
> > ```
> > Or
> > ```
> > ASSERT_EQ(1u, snapshot.values.count(...));
> > ```
> >
> > But I have to admit that `ASSERT_TRUE` is more readable. So it's up to you to decide if you want to keep the consistency or not ;)
Changed to `ASSERT_EQ`. While I also like above form with `ASSERT_TRUE` Mesos style in general seems to be to avoid implicit conversions to `bool`.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69719/#review211971
-----------------------------------------------------------
On Jan. 15, 2019, 10:27 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69719/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2019, 10:27 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and James DeFelice.
>
>
> Bugs: MESOS-9223
> https://issues.apache.org/jira/browse/MESOS-9223
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds monotonically increasing counters for subscriptions and
> disconnections of resource providers with the resource provider manager
> (`resource_provider_manager/subscriptions` and
> `resource_provider_manager/disconnections`, respectively). While the
> existing gauge `resource_provider_manager/subscribed` exposed the
> current state, these added counters can be used to monitor resource
> provider state for unexpected events.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 65852c629393f32fd582bfcff86d7ce14e5386ac
> src/tests/resource_provider_manager_tests.cpp 455ce7d2c71f2815430b69a5475b2ccc343cd9af
>
>
> Diff: https://reviews.apache.org/r/69719/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69719: Exposed subscriptions and disconnections RP
manager metrics.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69719/#review211971
-----------------------------------------------------------
src/resource_provider/manager.cpp
Lines 823-832 (original), 827-836 (patched)
<https://reviews.apache.org/r/69719/#comment297547>
How about moving this snippt to the end of this function, so the agent would receive `SUBSCRIBE` and then `DISCONNECT` no matter if the RP has a connection problem after it subscribes? This would also make the metric reveal the connection problem.
src/resource_provider/manager.cpp
Lines 1004-1005 (patched)
<https://reviews.apache.org/r/69719/#comment297548>
How about the following, to make it consistent with, e.g., `master/messages_register_framework`, and also make it less confusing w/ `resource_provider_manager/subscribed`?
```
messages_subscribe("resource_provider_manager/messages_subscribe"),
messages_disconnect("resource_provider_manager/messages_disconnect")
```
src/tests/resource_provider_manager_tests.cpp
Lines 1463-1468 (patched)
<https://reviews.apache.org/r/69719/#comment297550>
We usually do the following instead:
```
ASSERT_NE(0u, snapshot.values.count(...));
```
Or
```
ASSERT_EQ(1u, snapshot.values.count(...));
```
But I have to admit that `ASSERT_TRUE` is more readable. So it's up to you to decide if you want to keep the consistency or not ;)
src/tests/resource_provider_manager_tests.cpp
Lines 1470 (patched)
<https://reviews.apache.org/r/69719/#comment297551>
Maybe move all assertions related to a specific metric together? E.g.,
```
ASSERT_TRUE(snapshot.values.count(".../subscribed"));
EXPECT_EQ(0, snapshot.values.at(".../subscribed"));
ASSERT_TRUE(snapshot.values.count(".../subscriptions"));
EXPECT_EQ(0, snapshot.values.at(".../subscriptions"));
...
```
src/tests/resource_provider_manager_tests.cpp
Lines 1507-1509 (patched)
<https://reviews.apache.org/r/69719/#comment297553>
Shouldn't we test the existence of the metric keys, since this is a newly generated snapshot?
- Chun-Hung Hsiao
On Jan. 11, 2019, 10:02 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69719/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2019, 10:02 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and James DeFelice.
>
>
> Bugs: MESOS-9223
> https://issues.apache.org/jira/browse/MESOS-9223
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds monotonically increasing counters for subscriptions and
> disconnections of resource providers with the resource provider manager
> (`resource_provider_manager/subscriptions` and
> `resource_provider_manager/disconnections`, respectively). While the
> existing gauge `resource_provider_manager/subscribed` exposed the
> current state, these added counters can be used to monitor resource
> provider state for unexpected events.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 65852c629393f32fd582bfcff86d7ce14e5386ac
> src/tests/resource_provider_manager_tests.cpp 20cfb340bf634354865d79c92ee70cddca08f28a
>
>
> Diff: https://reviews.apache.org/r/69719/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69719: Exposed subscriptions and disconnections RP
manager metrics.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69719/#review211878
-----------------------------------------------------------
PASS: Mesos patch 69719 was successfully built and tested.
Reviews applied: `['69606', '69719']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2758/mesos-review-69719
- Mesos Reviewbot Windows
On Jan. 11, 2019, 10:02 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69719/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2019, 10:02 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and James DeFelice.
>
>
> Bugs: MESOS-9223
> https://issues.apache.org/jira/browse/MESOS-9223
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds monotonically increasing counters for subscriptions and
> disconnections of resource providers with the resource provider manager
> (`resource_provider_manager/subscriptions` and
> `resource_provider_manager/disconnections`, respectively). While the
> existing gauge `resource_provider_manager/subscribed` exposed the
> current state, these added counters can be used to monitor resource
> provider state for unexpected events.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 65852c629393f32fd582bfcff86d7ce14e5386ac
> src/tests/resource_provider_manager_tests.cpp 20cfb340bf634354865d79c92ee70cddca08f28a
>
>
> Diff: https://reviews.apache.org/r/69719/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69719: Exposed subscriptions and disconnections RP
manager metrics.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69719/#review212064
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['69606', '69719']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2788/mesos-review-69719
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2788/mesos-review-69719/logs/mesos-tests.log):
```
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_Logs
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_Default_CMD
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_Default_CMD_Override
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_Default_CMD_Args
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_SlaveRecoveryTaskContainer
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhileFetching
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[ FAILED ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull
28 FAILED TESTS
YOU HAVE 231 DISABLED TESTS
iner 09815b63-a075-4a36-bf07-91d9093985f6
W0116 13:04:02.912838 19120 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=9764 to peer '192.10.1.6:63935': IO failed with error code: The specified network name is no longer available.
W0116 13:04:02.913846 19120 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=9476 to peer '192.10.1.6:63934': IO failed with error code: The specified network name is no longer available.
I0116 13:04:03.001402 23564 containerizer.cpp:2975] Container 09815b63-a075-4a36-bf07-91d9093985f6 has exited
I0116 13:04:03.028391 26696 master.cpp:1109] Master terminating
I0116 13:04:03.030385 25860 hierarchical.cpp:644] Removed agent 837a9e14-937a-46a0-97f6-186aa45d7bf9-S0
I0116 13:04:03.533376 19120 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Jan. 16, 2019, 11:49 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69719/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2019, 11:49 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and James DeFelice.
>
>
> Bugs: MESOS-9223
> https://issues.apache.org/jira/browse/MESOS-9223
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds monotonically increasing counters for subscriptions and
> disconnections of resource providers with the resource provider manager
> (`resource_provider_manager/events/subscribed` and
> `resource_provider_manager/events/disconnects`, respectively). While the
> existing gauge `resource_provider_manager/subscribed` exposed the
> current state, these added counters can be used to monitor resource
> provider state for unexpected events.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 65852c629393f32fd582bfcff86d7ce14e5386ac
> src/tests/resource_provider_manager_tests.cpp 455ce7d2c71f2815430b69a5475b2ccc343cd9af
>
>
> Diff: https://reviews.apache.org/r/69719/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69719: Exposed subscriptions and disconnections RP
manager metrics.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69719/#review212099
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On Jan. 16, 2019, 11:49 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69719/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2019, 11:49 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and James DeFelice.
>
>
> Bugs: MESOS-9223
> https://issues.apache.org/jira/browse/MESOS-9223
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds monotonically increasing counters for subscriptions and
> disconnections of resource providers with the resource provider manager
> (`resource_provider_manager/events/subscribed` and
> `resource_provider_manager/events/disconnects`, respectively). While the
> existing gauge `resource_provider_manager/subscribed` exposed the
> current state, these added counters can be used to monitor resource
> provider state for unexpected events.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 65852c629393f32fd582bfcff86d7ce14e5386ac
> src/tests/resource_provider_manager_tests.cpp 455ce7d2c71f2815430b69a5475b2ccc343cd9af
>
>
> Diff: https://reviews.apache.org/r/69719/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69719: Exposed subscriptions and disconnections RP
manager metrics.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69719/
-----------------------------------------------------------
(Updated Jan. 16, 2019, 12:49 p.m.)
Review request for mesos, Chun-Hung Hsiao and James DeFelice.
Changes
-------
Addressed comment from Chun.
Bugs: MESOS-9223
https://issues.apache.org/jira/browse/MESOS-9223
Repository: mesos
Description (updated)
-------
This patch adds monotonically increasing counters for subscriptions and
disconnections of resource providers with the resource provider manager
(`resource_provider_manager/events/subscribed` and
`resource_provider_manager/events/disconnects`, respectively). While the
existing gauge `resource_provider_manager/subscribed` exposed the
current state, these added counters can be used to monitor resource
provider state for unexpected events.
Diffs (updated)
-----
src/resource_provider/manager.cpp 65852c629393f32fd582bfcff86d7ce14e5386ac
src/tests/resource_provider_manager_tests.cpp 455ce7d2c71f2815430b69a5475b2ccc343cd9af
Diff: https://reviews.apache.org/r/69719/diff/3/
Changes: https://reviews.apache.org/r/69719/diff/2-3/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69719: Exposed subscriptions and disconnections RP
manager metrics.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69719/#review212031
-----------------------------------------------------------
PASS: Mesos patch 69719 was successfully built and tested.
Reviews applied: `['69606', '69719']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2781/mesos-review-69719
- Mesos Reviewbot Windows
On Jan. 15, 2019, 1:27 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69719/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2019, 1:27 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and James DeFelice.
>
>
> Bugs: MESOS-9223
> https://issues.apache.org/jira/browse/MESOS-9223
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds monotonically increasing counters for subscriptions and
> disconnections of resource providers with the resource provider manager
> (`resource_provider_manager/subscriptions` and
> `resource_provider_manager/disconnections`, respectively). While the
> existing gauge `resource_provider_manager/subscribed` exposed the
> current state, these added counters can be used to monitor resource
> provider state for unexpected events.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.cpp 65852c629393f32fd582bfcff86d7ce14e5386ac
> src/tests/resource_provider_manager_tests.cpp 455ce7d2c71f2815430b69a5475b2ccc343cd9af
>
>
> Diff: https://reviews.apache.org/r/69719/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69719: Exposed subscriptions and disconnections RP
manager metrics.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69719/
-----------------------------------------------------------
(Updated Jan. 15, 2019, 10:27 a.m.)
Review request for mesos, Chun-Hung Hsiao and James DeFelice.
Changes
-------
Addressed some comments from Chun.
Bugs: MESOS-9223
https://issues.apache.org/jira/browse/MESOS-9223
Repository: mesos
Description
-------
This patch adds monotonically increasing counters for subscriptions and
disconnections of resource providers with the resource provider manager
(`resource_provider_manager/subscriptions` and
`resource_provider_manager/disconnections`, respectively). While the
existing gauge `resource_provider_manager/subscribed` exposed the
current state, these added counters can be used to monitor resource
provider state for unexpected events.
Diffs (updated)
-----
src/resource_provider/manager.cpp 65852c629393f32fd582bfcff86d7ce14e5386ac
src/tests/resource_provider_manager_tests.cpp 455ce7d2c71f2815430b69a5475b2ccc343cd9af
Diff: https://reviews.apache.org/r/69719/diff/2/
Changes: https://reviews.apache.org/r/69719/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier