You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Bilgin Ibryam (Created) (JIRA)" <ji...@apache.org> on 2012/01/17 14:21:41 UTC
[jira] [Created] (CAMEL-4908) Twitter component fixes
Twitter component fixes
-----------------------
Key: CAMEL-4908
URL: https://issues.apache.org/jira/browse/CAMEL-4908
Project: Camel
Issue Type: Bug
Reporter: Bilgin Ibryam
Attachments: twitter.diff
Fix ConcurrentModificationException for StreamingConsumer.
Fix NPE for FilterConsumer
Use additional query parameters for FilterConsumer like userIds, keywords.
I didn't added tests for these fixes, because currently it seems like it connects to the internet and does real twitter queries. I will check this in a separate issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4908) Twitter component fixes
Posted by "Claus Ibsen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187673#comment-13187673 ]
Claus Ibsen commented on CAMEL-4908:
------------------------------------
Bilgin you may want to read about checkstyle, so you can run a test to run a report on the command line, which tells you if the source code is aligned as it should (eg indent, parenthesis, and whatnot)
See building with checkstyle here:
http://camel.apache.org/building.html
And btw I do not think you need to create a new ArrayList when you guard it as unmodified, as the caller will not be able to modify the list.
return Collections.unmodifiableList(new ArrayList(receivedStatuses));
> Twitter component fixes
> -----------------------
>
> Key: CAMEL-4908
> URL: https://issues.apache.org/jira/browse/CAMEL-4908
> Project: Camel
> Issue Type: Bug
> Components: camel-twitter
> Affects Versions: 2.10.0
> Reporter: Bilgin Ibryam
> Fix For: 2.10.0
>
> Attachments: twitter.diff
>
>
> Fix ConcurrentModificationException for StreamingConsumer.
> Fix NPE for FilterConsumer
> Use additional query parameters for FilterConsumer like userIds, keywords.
> I didn't added tests for these fixes, because currently it seems like it connects to the internet and does real twitter queries. I will check this in a separate issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4908) Twitter component fixes
Posted by "Babak Vahdat (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192015#comment-13192015 ]
Babak Vahdat commented on CAMEL-4908:
-------------------------------------
I've got no experience of using IntelliJ but the problem you are facing seems really odd to me if IntelliJ doesn't honor the given settings. I would expect any given IDE to do all the formattings automatically!
AKAIK Claus makes use of IntelliJ and maybe he can help you here.
> Twitter component fixes
> -----------------------
>
> Key: CAMEL-4908
> URL: https://issues.apache.org/jira/browse/CAMEL-4908
> Project: Camel
> Issue Type: Bug
> Components: camel-twitter
> Affects Versions: 2.10.0
> Reporter: Bilgin Ibryam
> Assignee: Bilgin Ibryam
> Priority: Minor
> Fix For: 2.10.0
>
> Attachments: twitter.diff
>
>
> Fix ConcurrentModificationException for StreamingConsumer.
> Fix NPE for FilterConsumer
> Use additional query parameters for FilterConsumer like userIds, keywords.
> I didn't added tests for these fixes, because currently it seems like it connects to the internet and does real twitter queries. I will check this in a separate issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4908) Twitter component fixes
Posted by "Babak Vahdat (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187729#comment-13187729 ]
Babak Vahdat commented on CAMEL-4908:
-------------------------------------
@Bilgin
Personally I do use eclipse but in your case applying [1] will do the trick. Please also check [2] just in the case you don't know how to apply it to your IntelliJ installation.
[1] https://svn.apache.org/repos/asf/camel/trunk/etc/idea/settings.jar
[2] http://musingsofaprogrammingaddict.blogspot.com/2010/03/import-code-style-settings-into.html
> Twitter component fixes
> -----------------------
>
> Key: CAMEL-4908
> URL: https://issues.apache.org/jira/browse/CAMEL-4908
> Project: Camel
> Issue Type: Bug
> Components: camel-twitter
> Affects Versions: 2.10.0
> Reporter: Bilgin Ibryam
> Assignee: Bilgin Ibryam
> Priority: Minor
> Fix For: 2.10.0
>
> Attachments: twitter.diff
>
>
> Fix ConcurrentModificationException for StreamingConsumer.
> Fix NPE for FilterConsumer
> Use additional query parameters for FilterConsumer like userIds, keywords.
> I didn't added tests for these fixes, because currently it seems like it connects to the internet and does real twitter queries. I will check this in a separate issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4908) Twitter component fixes
Posted by "Bilgin Ibryam (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187720#comment-13187720 ]
Bilgin Ibryam commented on CAMEL-4908:
--------------------------------------
I will pay more attention to CS. My editor intelliJ orders the imports in different order and I don't know the order expected from CS, will spent some time there.
About:
return Collections.unmodifiableList(new ArrayList(receivedStatuses));
the caller is not able to modify the array, but while the caller is iterating the source array is modified with clear/add methods and that's causing the error mentioned previously
> Twitter component fixes
> -----------------------
>
> Key: CAMEL-4908
> URL: https://issues.apache.org/jira/browse/CAMEL-4908
> Project: Camel
> Issue Type: Bug
> Components: camel-twitter
> Affects Versions: 2.10.0
> Reporter: Bilgin Ibryam
> Assignee: Bilgin Ibryam
> Priority: Minor
> Fix For: 2.10.0
>
> Attachments: twitter.diff
>
>
> Fix ConcurrentModificationException for StreamingConsumer.
> Fix NPE for FilterConsumer
> Use additional query parameters for FilterConsumer like userIds, keywords.
> I didn't added tests for these fixes, because currently it seems like it connects to the internet and does real twitter queries. I will check this in a separate issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CAMEL-4908) Twitter component fixes
Posted by "Claus Ibsen (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-4908.
--------------------------------
Resolution: Fixed
Thanks for the patch.
I have fixed CS.
> Twitter component fixes
> -----------------------
>
> Key: CAMEL-4908
> URL: https://issues.apache.org/jira/browse/CAMEL-4908
> Project: Camel
> Issue Type: Bug
> Components: camel-twitter
> Affects Versions: 2.10.0
> Reporter: Bilgin Ibryam
> Assignee: Bilgin Ibryam
> Priority: Minor
> Fix For: 2.10.0
>
> Attachments: twitter.diff
>
>
> Fix ConcurrentModificationException for StreamingConsumer.
> Fix NPE for FilterConsumer
> Use additional query parameters for FilterConsumer like userIds, keywords.
> I didn't added tests for these fixes, because currently it seems like it connects to the internet and does real twitter queries. I will check this in a separate issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-4908) Twitter component fixes
Posted by "Bilgin Ibryam (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191810#comment-13191810 ]
Bilgin Ibryam commented on CAMEL-4908:
--------------------------------------
Thanks for the info Babak. I installed the settings following the instructions, but still have to do some formatting manually, like indenting "throws" statements at 8 spaces instead of 12. Is this expected behaviour or the IDE should do all the formatting automatically?
> Twitter component fixes
> -----------------------
>
> Key: CAMEL-4908
> URL: https://issues.apache.org/jira/browse/CAMEL-4908
> Project: Camel
> Issue Type: Bug
> Components: camel-twitter
> Affects Versions: 2.10.0
> Reporter: Bilgin Ibryam
> Assignee: Bilgin Ibryam
> Priority: Minor
> Fix For: 2.10.0
>
> Attachments: twitter.diff
>
>
> Fix ConcurrentModificationException for StreamingConsumer.
> Fix NPE for FilterConsumer
> Use additional query parameters for FilterConsumer like userIds, keywords.
> I didn't added tests for these fixes, because currently it seems like it connects to the internet and does real twitter queries. I will check this in a separate issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CAMEL-4908) Twitter component fixes
Posted by "Babak Vahdat (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192015#comment-13192015 ]
Babak Vahdat edited comment on CAMEL-4908 at 1/24/12 8:45 AM:
--------------------------------------------------------------
I've got no experience of using IntelliJ but the problem you are facing seems really odd to me if IntelliJ doesn't honor the given settings. I would expect any given IDE to do all the formattings automatically!
AFAIK Claus makes use of IntelliJ and maybe he can help you here.
was (Author: bvahdat):
I've got no experience of using IntelliJ but the problem you are facing seems really odd to me if IntelliJ doesn't honor the given settings. I would expect any given IDE to do all the formattings automatically!
AKAIK Claus makes use of IntelliJ and maybe he can help you here.
> Twitter component fixes
> -----------------------
>
> Key: CAMEL-4908
> URL: https://issues.apache.org/jira/browse/CAMEL-4908
> Project: Camel
> Issue Type: Bug
> Components: camel-twitter
> Affects Versions: 2.10.0
> Reporter: Bilgin Ibryam
> Assignee: Bilgin Ibryam
> Priority: Minor
> Fix For: 2.10.0
>
> Attachments: twitter.diff
>
>
> Fix ConcurrentModificationException for StreamingConsumer.
> Fix NPE for FilterConsumer
> Use additional query parameters for FilterConsumer like userIds, keywords.
> I didn't added tests for these fixes, because currently it seems like it connects to the internet and does real twitter queries. I will check this in a separate issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4908) Twitter component fixes
Posted by "Claus Ibsen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-4908:
-------------------------------
Component/s: camel-twitter
Priority: Minor (was: Major)
Affects Version/s: 2.10.0
Fix Version/s: 2.10.0
> Twitter component fixes
> -----------------------
>
> Key: CAMEL-4908
> URL: https://issues.apache.org/jira/browse/CAMEL-4908
> Project: Camel
> Issue Type: Bug
> Components: camel-twitter
> Affects Versions: 2.10.0
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: 2.10.0
>
> Attachments: twitter.diff
>
>
> Fix ConcurrentModificationException for StreamingConsumer.
> Fix NPE for FilterConsumer
> Use additional query parameters for FilterConsumer like userIds, keywords.
> I didn't added tests for these fixes, because currently it seems like it connects to the internet and does real twitter queries. I will check this in a separate issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-4908) Twitter component fixes
Posted by "Bilgin Ibryam (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bilgin Ibryam updated CAMEL-4908:
---------------------------------
Attachment: twitter.diff
> Twitter component fixes
> -----------------------
>
> Key: CAMEL-4908
> URL: https://issues.apache.org/jira/browse/CAMEL-4908
> Project: Camel
> Issue Type: Bug
> Reporter: Bilgin Ibryam
> Attachments: twitter.diff
>
>
> Fix ConcurrentModificationException for StreamingConsumer.
> Fix NPE for FilterConsumer
> Use additional query parameters for FilterConsumer like userIds, keywords.
> I didn't added tests for these fixes, because currently it seems like it connects to the internet and does real twitter queries. I will check this in a separate issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CAMEL-4908) Twitter component fixes
Posted by "Claus Ibsen (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned CAMEL-4908:
----------------------------------
Assignee: Bilgin Ibryam
> Twitter component fixes
> -----------------------
>
> Key: CAMEL-4908
> URL: https://issues.apache.org/jira/browse/CAMEL-4908
> Project: Camel
> Issue Type: Bug
> Components: camel-twitter
> Affects Versions: 2.10.0
> Reporter: Bilgin Ibryam
> Assignee: Bilgin Ibryam
> Priority: Minor
> Fix For: 2.10.0
>
> Attachments: twitter.diff
>
>
> Fix ConcurrentModificationException for StreamingConsumer.
> Fix NPE for FilterConsumer
> Use additional query parameters for FilterConsumer like userIds, keywords.
> I didn't added tests for these fixes, because currently it seems like it connects to the internet and does real twitter queries. I will check this in a separate issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CAMEL-4908) Twitter component fixes
Posted by "Claus Ibsen (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187673#comment-13187673 ]
Claus Ibsen edited comment on CAMEL-4908 at 1/17/12 1:30 PM:
-------------------------------------------------------------
Bilgin you may want to read about checkstyle, so you can run a test to run a report on the command line, which tells you if the source code is aligned as it should (eg indent, parenthesis, and whatnot)
See building with checkstyle here:
http://camel.apache.org/building.html
And btw I do not think you need to create a new ArrayList when you guard it as unmodified, as the caller will not be able to modify the list.
Or did I miss a point? If so please add a code comment in the source why this is done as is
return Collections.unmodifiableList(new ArrayList(receivedStatuses));
was (Author: davsclaus):
Bilgin you may want to read about checkstyle, so you can run a test to run a report on the command line, which tells you if the source code is aligned as it should (eg indent, parenthesis, and whatnot)
See building with checkstyle here:
http://camel.apache.org/building.html
And btw I do not think you need to create a new ArrayList when you guard it as unmodified, as the caller will not be able to modify the list.
return Collections.unmodifiableList(new ArrayList(receivedStatuses));
> Twitter component fixes
> -----------------------
>
> Key: CAMEL-4908
> URL: https://issues.apache.org/jira/browse/CAMEL-4908
> Project: Camel
> Issue Type: Bug
> Components: camel-twitter
> Affects Versions: 2.10.0
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: 2.10.0
>
> Attachments: twitter.diff
>
>
> Fix ConcurrentModificationException for StreamingConsumer.
> Fix NPE for FilterConsumer
> Use additional query parameters for FilterConsumer like userIds, keywords.
> I didn't added tests for these fixes, because currently it seems like it connects to the internet and does real twitter queries. I will check this in a separate issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira