You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by Daniel Kulp <dk...@apache.org> on 2007/11/01 15:15:21 UTC
Maven version for CXF.....
I was looking into:
https://issues.apache.org/jira/browse/CXF-1163
and it does seem to be a maven version issue. Maven 2.0.7 seems to
generate the proper manifest. 2.0.5 does not. Thus, I'd like to
update the prerequisites to 2.0.7. Maven 2.0.7 has been out for
several months. (actually, 2.0.8 is due real soon)
Anyone have issue with that?
--
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727 C: 508-380-7194
daniel.kulp@iona.com
http://www.dankulp.com/blog
Disabled PMD rule "AssignmentInOperand"
Posted by "Liu, Jervis" <jl...@iona.com>.
Hi,
I disabled PMD rule "AssignmentInOperand", i.e., "Avoid assignments in operands.". The code in question is as below:
byte[] tmp = new byte[4096];
int i = 0;
InputStream is = new FileInputStream(inputFile);
try {
while ((i = is.read(tmp)) >= 0) {
outputstream.write(tmp, 0, i);
}
} finally {
is.close();
}
I've already committed this change as I believe the snippet above is the best way to write this code. Having that said, you still have a chance to shout out if you strongly against this change :-)
Cheers,
Jervis
----------------------------
IONA Technologies PLC (registered in Ireland)
Registered Number: 171387
Registered Address: The IONA Building, Shelbourne Road, Dublin 4, Ireland
RE: Maven version for CXF.....
Posted by "Liu, Jervis" <jl...@iona.com>.
Ok. I saw Dan has fixed this by forcing HttpClient using commons-logging-1.1.jar. I've had a quick test, HttpClient works with commons-logging 1.1. Anyway, we only use HttpClient to demonstrate a client that can access RESTful services.
Cheers,
Jervis
> -----Original Message-----
> From: Liu, Jervis [mailto:jliu@iona.com]
> Sent: 2007?11?2? 9:58
> To: Daniel Kulp; cxf-dev@incubator.apache.org
> Cc: Jiang, Ning (Willem)
> Subject: RE: Maven version for CXF.....
>
>
> Actually I was a bit hesitated when I wrote the restful_jaxrs
> demo client using httpClient. The reason I was hesitated was
> precisely same as Dan has pointed out, is it justified to add
> a new dependency only for the purpose of demo? I went ahead
> to use HttpClient as I found using HttpClient does relieve a
> user from writing trivial and low level code such as handling
> stream writing etc thus the demo itself is more
> illustratable. Of course we can provide an utility
> class/method on top of HttpURLConnection, but then we turned
> ourselves into another implementation of HttpClient.
>
> Solutions: It might be hard for Maven to handle this
> situation. If we can not find a way around to fix this
> version problem, then I will rewrite restful_jaxrs using
> HttpURLConnection. Otherwise I would suggest we keep
> HttpClient. Thoughts?
>
> Cheers,
> Jervis
>
> > -----Original Message-----
> > From: Daniel Kulp [mailto:dkulp@apache.org]
> > Sent: 2007?11?2? 2:18
> > To: cxf-dev@incubator.apache.org; Liu, Jervis
> > Cc: Jiang, Ning (Willem)
> > Subject: Re: Maven version for CXF.....
> >
> >
> >
> > Tracked this down. The addition of commons-httpclient is
> pulling in
> > 1.0.4 into distribution.
> >
> > Looking at the code, the only place that it is used is in the
> > new rest
> > demo. Jervis: can that demo be re-written to just use an
> > HTTPUrlConnection? Nothing at runtime uses it so I really
> > would prefer
> > not to ship it if we don't have to.
> >
> > Dan
> >
> >
> > On Thursday 01 November 2007, Daniel Kulp wrote:
> > > Actually, it's fairly interesting. With maven 2.0.7, 1.1
> > gets put in
> > > the manifest, but 1.0.4 into lib. With maven 2.0.5,
> it's reversed.
> > >
> > > I'll dig into it more. :-(
> > >
> > > Dan
> > >
> > > On Thursday 01 November 2007, Daniel Kulp wrote:
> > > > Willem,
> > > >
> > > > With 2.0.7, can you run:
> > > > "mvn install -X"
> > > > in the manifest directory and send me the output?
> > (offline direct,
> > > > not to the list) I can dig into that and hopefully
> > figure it out.
> > > >
> > > >
> > > > Dan
> > > >
> > > > On Thursday 01 November 2007, Jiang, Ning (Willem) wrote:
> > > > > Hi Dan,
> > > > >
> > > > > I used maven 2.0.7 to build the kit, and also have
> the issue of
> > > > > CXF-1163. I do know who introduces the common log
> 1.0.4.jar into
> > > > > the assemble plugin. Our manifest uses the common log 1.1 jar
> > > > > instead.
> > > > >
> > > > > Willem.
> > > > >
> > > > > -----Original Message-----
> > > > > From: Daniel Kulp [mailto:dkulp@apache.org]
> > > > > Sent: Thu 11/1/2007 22:15
> > > > > To: cxf-dev@incubator.apache.org
> > > > > Subject: Maven version for CXF.....
> > > > >
> > > > >
> > > > > I was looking into:
> > > > > https://issues.apache.org/jira/browse/CXF-1163
> > > > >
> > > > > and it does seem to be a maven version issue. Maven
> > 2.0.7 seems
> > > > > to generate the proper manifest. 2.0.5 does not. Thus, I'd
> > > > > like to update the prerequisites to 2.0.7. Maven
> > 2.0.7 has been
> > > > > out for several months. (actually, 2.0.8 is due real soon)
> > > > >
> > > > > Anyone have issue with that?
> >
> >
> >
> > --
> > J. Daniel Kulp
> > Principal Engineer
> > IONA
> > P: 781-902-8727 C: 508-380-7194
> > daniel.kulp@iona.com
> > http://www.dankulp.com/blog
> >
>
> ----------------------------
> IONA Technologies PLC (registered in Ireland)
> Registered Number: 171387
> Registered Address: The IONA Building, Shelbourne Road,
> Dublin 4, Ireland
>
----------------------------
IONA Technologies PLC (registered in Ireland)
Registered Number: 171387
Registered Address: The IONA Building, Shelbourne Road, Dublin 4, Ireland
RE: Maven version for CXF.....
Posted by "Liu, Jervis" <jl...@iona.com>.
Actually I was a bit hesitated when I wrote the restful_jaxrs demo client using httpClient. The reason I was hesitated was precisely same as Dan has pointed out, is it justified to add a new dependency only for the purpose of demo? I went ahead to use HttpClient as I found using HttpClient does relieve a user from writing trivial and low level code such as handling stream writing etc thus the demo itself is more illustratable. Of course we can provide an utility class/method on top of HttpURLConnection, but then we turned ourselves into another implementation of HttpClient.
Solutions: It might be hard for Maven to handle this situation. If we can not find a way around to fix this version problem, then I will rewrite restful_jaxrs using HttpURLConnection. Otherwise I would suggest we keep HttpClient. Thoughts?
Cheers,
Jervis
> -----Original Message-----
> From: Daniel Kulp [mailto:dkulp@apache.org]
> Sent: 2007?11?2? 2:18
> To: cxf-dev@incubator.apache.org; Liu, Jervis
> Cc: Jiang, Ning (Willem)
> Subject: Re: Maven version for CXF.....
>
>
>
> Tracked this down. The addition of commons-httpclient is pulling in
> 1.0.4 into distribution.
>
> Looking at the code, the only place that it is used is in the
> new rest
> demo. Jervis: can that demo be re-written to just use an
> HTTPUrlConnection? Nothing at runtime uses it so I really
> would prefer
> not to ship it if we don't have to.
>
> Dan
>
>
> On Thursday 01 November 2007, Daniel Kulp wrote:
> > Actually, it's fairly interesting. With maven 2.0.7, 1.1
> gets put in
> > the manifest, but 1.0.4 into lib. With maven 2.0.5, it's reversed.
> >
> > I'll dig into it more. :-(
> >
> > Dan
> >
> > On Thursday 01 November 2007, Daniel Kulp wrote:
> > > Willem,
> > >
> > > With 2.0.7, can you run:
> > > "mvn install -X"
> > > in the manifest directory and send me the output?
> (offline direct,
> > > not to the list) I can dig into that and hopefully
> figure it out.
> > >
> > >
> > > Dan
> > >
> > > On Thursday 01 November 2007, Jiang, Ning (Willem) wrote:
> > > > Hi Dan,
> > > >
> > > > I used maven 2.0.7 to build the kit, and also have the issue of
> > > > CXF-1163. I do know who introduces the common log 1.0.4.jar into
> > > > the assemble plugin. Our manifest uses the common log 1.1 jar
> > > > instead.
> > > >
> > > > Willem.
> > > >
> > > > -----Original Message-----
> > > > From: Daniel Kulp [mailto:dkulp@apache.org]
> > > > Sent: Thu 11/1/2007 22:15
> > > > To: cxf-dev@incubator.apache.org
> > > > Subject: Maven version for CXF.....
> > > >
> > > >
> > > > I was looking into:
> > > > https://issues.apache.org/jira/browse/CXF-1163
> > > >
> > > > and it does seem to be a maven version issue. Maven
> 2.0.7 seems
> > > > to generate the proper manifest. 2.0.5 does not. Thus, I'd
> > > > like to update the prerequisites to 2.0.7. Maven
> 2.0.7 has been
> > > > out for several months. (actually, 2.0.8 is due real soon)
> > > >
> > > > Anyone have issue with that?
>
>
>
> --
> J. Daniel Kulp
> Principal Engineer
> IONA
> P: 781-902-8727 C: 508-380-7194
> daniel.kulp@iona.com
> http://www.dankulp.com/blog
>
----------------------------
IONA Technologies PLC (registered in Ireland)
Registered Number: 171387
Registered Address: The IONA Building, Shelbourne Road, Dublin 4, Ireland
Re: Maven version for CXF.....
Posted by Daniel Kulp <dk...@apache.org>.
Tracked this down. The addition of commons-httpclient is pulling in
1.0.4 into distribution.
Looking at the code, the only place that it is used is in the new rest
demo. Jervis: can that demo be re-written to just use an
HTTPUrlConnection? Nothing at runtime uses it so I really would prefer
not to ship it if we don't have to.
Dan
On Thursday 01 November 2007, Daniel Kulp wrote:
> Actually, it's fairly interesting. With maven 2.0.7, 1.1 gets put in
> the manifest, but 1.0.4 into lib. With maven 2.0.5, it's reversed.
>
> I'll dig into it more. :-(
>
> Dan
>
> On Thursday 01 November 2007, Daniel Kulp wrote:
> > Willem,
> >
> > With 2.0.7, can you run:
> > "mvn install -X"
> > in the manifest directory and send me the output? (offline direct,
> > not to the list) I can dig into that and hopefully figure it out.
> >
> >
> > Dan
> >
> > On Thursday 01 November 2007, Jiang, Ning (Willem) wrote:
> > > Hi Dan,
> > >
> > > I used maven 2.0.7 to build the kit, and also have the issue of
> > > CXF-1163. I do know who introduces the common log 1.0.4.jar into
> > > the assemble plugin. Our manifest uses the common log 1.1 jar
> > > instead.
> > >
> > > Willem.
> > >
> > > -----Original Message-----
> > > From: Daniel Kulp [mailto:dkulp@apache.org]
> > > Sent: Thu 11/1/2007 22:15
> > > To: cxf-dev@incubator.apache.org
> > > Subject: Maven version for CXF.....
> > >
> > >
> > > I was looking into:
> > > https://issues.apache.org/jira/browse/CXF-1163
> > >
> > > and it does seem to be a maven version issue. Maven 2.0.7 seems
> > > to generate the proper manifest. 2.0.5 does not. Thus, I'd
> > > like to update the prerequisites to 2.0.7. Maven 2.0.7 has been
> > > out for several months. (actually, 2.0.8 is due real soon)
> > >
> > > Anyone have issue with that?
--
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727 C: 508-380-7194
daniel.kulp@iona.com
http://www.dankulp.com/blog
Re: Maven version for CXF.....
Posted by Daniel Kulp <dk...@apache.org>.
Actually, it's fairly interesting. With maven 2.0.7, 1.1 gets put in
the manifest, but 1.0.4 into lib. With maven 2.0.5, it's reversed.
I'll dig into it more. :-(
Dan
On Thursday 01 November 2007, Daniel Kulp wrote:
> Willem,
>
> With 2.0.7, can you run:
> "mvn install -X"
> in the manifest directory and send me the output? (offline direct,
> not to the list) I can dig into that and hopefully figure it out.
>
>
> Dan
>
> On Thursday 01 November 2007, Jiang, Ning (Willem) wrote:
> > Hi Dan,
> >
> > I used maven 2.0.7 to build the kit, and also have the issue of
> > CXF-1163. I do know who introduces the common log 1.0.4.jar into the
> > assemble plugin. Our manifest uses the common log 1.1 jar instead.
> >
> > Willem.
> >
> > -----Original Message-----
> > From: Daniel Kulp [mailto:dkulp@apache.org]
> > Sent: Thu 11/1/2007 22:15
> > To: cxf-dev@incubator.apache.org
> > Subject: Maven version for CXF.....
> >
> >
> > I was looking into:
> > https://issues.apache.org/jira/browse/CXF-1163
> >
> > and it does seem to be a maven version issue. Maven 2.0.7 seems to
> > generate the proper manifest. 2.0.5 does not. Thus, I'd like to
> > update the prerequisites to 2.0.7. Maven 2.0.7 has been out for
> > several months. (actually, 2.0.8 is due real soon)
> >
> > Anyone have issue with that?
--
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727 C: 508-380-7194
daniel.kulp@iona.com
http://www.dankulp.com/blog
Re: Maven version for CXF.....
Posted by Daniel Kulp <dk...@apache.org>.
Willem,
With 2.0.7, can you run:
"mvn install -X"
in the manifest directory and send me the output? (offline direct, not
to the list) I can dig into that and hopefully figure it out.
Dan
On Thursday 01 November 2007, Jiang, Ning (Willem) wrote:
> Hi Dan,
>
> I used maven 2.0.7 to build the kit, and also have the issue of
> CXF-1163. I do know who introduces the common log 1.0.4.jar into the
> assemble plugin. Our manifest uses the common log 1.1 jar instead.
>
> Willem.
>
> -----Original Message-----
> From: Daniel Kulp [mailto:dkulp@apache.org]
> Sent: Thu 11/1/2007 22:15
> To: cxf-dev@incubator.apache.org
> Subject: Maven version for CXF.....
>
>
> I was looking into:
> https://issues.apache.org/jira/browse/CXF-1163
>
> and it does seem to be a maven version issue. Maven 2.0.7 seems to
> generate the proper manifest. 2.0.5 does not. Thus, I'd like to
> update the prerequisites to 2.0.7. Maven 2.0.7 has been out for
> several months. (actually, 2.0.8 is due real soon)
>
> Anyone have issue with that?
--
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727 C: 508-380-7194
daniel.kulp@iona.com
http://www.dankulp.com/blog
RE: Maven version for CXF.....
Posted by "Jiang, Ning (Willem)" <Ni...@iona.com>.
Hi Dan,
I used maven 2.0.7 to build the kit, and also have the issue of CXF-1163.
I do know who introduces the common log 1.0.4.jar into the assemble plugin.
Our manifest uses the common log 1.1 jar instead.
Willem.
-----Original Message-----
From: Daniel Kulp [mailto:dkulp@apache.org]
Sent: Thu 11/1/2007 22:15
To: cxf-dev@incubator.apache.org
Subject: Maven version for CXF.....
I was looking into:
https://issues.apache.org/jira/browse/CXF-1163
and it does seem to be a maven version issue. Maven 2.0.7 seems to
generate the proper manifest. 2.0.5 does not. Thus, I'd like to
update the prerequisites to 2.0.7. Maven 2.0.7 has been out for
several months. (actually, 2.0.8 is due real soon)
Anyone have issue with that?
--
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727 C: 508-380-7194
daniel.kulp@iona.com
http://www.dankulp.com/blog