Re: [PR] Include ALL modifier for set operators in multi-stage query engine physical explain plan [pinot]

["gortiz (via GitHub)" <gi...@apache.org>]

gortiz commented on code in PR #13166:
URL: https://github.com/apache/pinot/pull/13166#discussion_r1602798766


##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/SetOpNode.java:
##########
@@ -57,7 +57,7 @@ public boolean isAll() {
 
   @Override
   public String explain() {
-    return _setOpType.toString();
+    return _all ? _setOpType.toString() + "_ALL" : _setOpType.toString();

Review Comment:
   Does it works in `Union`? AFAIR union always behaves as `all = true`. Is this attribute always true in `union`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org