[GitHub] [ozone] sodonnel commented on a change in pull request #3041: HDDS-6250. EC: Add replica index to the output in the container info command

[GitBox <gi...@apache.org>]

sodonnel commented on a change in pull request #3041:
URL: https://github.com/apache/ozone/pull/3041#discussion_r799810716



##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerReplicaInfo.java
##########
@@ -45,7 +46,9 @@ public static ContainerReplicaInfo fromProto(
         .setPlaceOfBirth(UUID.fromString(proto.getPlaceOfBirth()))
         .setSequenceId(proto.getSequenceID())
         .setKeyCount(proto.getKeyCount())
-        .setBytesUsed(proto.getBytesUsed());
+        .setBytesUsed(proto.getBytesUsed())
+        .setReplicaIndex(

Review comment:
       I was using "-1" as a case to indicate that the index is not in the proto at all. Ie, SCM is at an older version than the client. Ideally this should not happen except during an upgrade window from pre-EC to the EC release, and then never again.
   
   When displaying the index, I have some logic to not display it at all if its -1. Otherwise display it even if it is zero.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org