[GitHub] [hive] miklosgergely commented on a change in pull request #757: HIVE-22143 Break up DDLSemanticAnalyzer - extract Database related analyzers

[GitBox <gi...@apache.org>]

miklosgergely commented on a change in pull request #757: HIVE-22143 Break up DDLSemanticAnalyzer - extract Database related analyzers
URL: https://github.com/apache/hive/pull/757#discussion_r321586556
 
 

 ##########
 File path: hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
 ##########
 @@ -21,10 +21,10 @@
 import org.apache.hadoop.hive.metastore.api.Database;
 import org.apache.hadoop.hive.ql.ddl.DDLDesc;
 import org.apache.hadoop.hive.ql.ddl.DDLWork;
-import org.apache.hadoop.hive.ql.ddl.database.DescDatabaseDesc;
-import org.apache.hadoop.hive.ql.ddl.database.DropDatabaseDesc;
-import org.apache.hadoop.hive.ql.ddl.database.ShowDatabasesDesc;
-import org.apache.hadoop.hive.ql.ddl.database.SwitchDatabaseDesc;
+import org.apache.hadoop.hive.ql.ddl.database.desc.DescDatabaseDesc;
+import org.apache.hadoop.hive.ql.ddl.database.drop.DropDatabaseDesc;
+import org.apache.hadoop.hive.ql.ddl.database.show.ShowDatabasesDesc;
+import org.apache.hadoop.hive.ql.ddl.database.switchdb.SwitchDatabaseDesc;
 
 Review comment:
   "switch" is a reserved word in java, and thus it can not be used even as a segment of a package name :)
   
   Bt probably it could be modified to "use". Do you agree?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org