You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ja...@apache.org on 2014/07/03 03:47:50 UTC
svn commit: r1607514 - in /pdfbox/trunk:
examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java
pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/SignatureOptions.java
Author: jahewson
Date: Thu Jul 3 01:47:50 2014
New Revision: 1607514
URL: http://svn.apache.org/r1607514
Log:
PDFBOX-2038: add close() method to SignatureOptions
Modified:
pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/SignatureOptions.java
Modified: pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java?rev=1607514&r1=1607513&r2=1607514&view=diff
==============================================================================
--- pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java (original)
+++ pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java Thu Jul 3 01:47:50 2014
@@ -147,11 +147,21 @@ public class CreateVisibleSignature impl
if (signatureProperties != null && signatureProperties.isVisualSignEnabled())
{
- options = new SignatureOptions();
- options.setVisualSignature(signatureProperties);
- // options.setPage(signatureProperties.getPage());
- // options.setPreferedSignatureSize(signatureProperties.getPreferredSize());
- doc.addSignature(signature, this, options);
+ try
+ {
+ options = new SignatureOptions();
+ options.setVisualSignature(signatureProperties);
+ // options.setPage(signatureProperties.getPage());
+ // options.setPreferedSignatureSize(signatureProperties.getPreferredSize());
+ doc.addSignature(signature, this, options);
+ }
+ finally
+ {
+ if (options != null)
+ {
+ options.close();
+ }
+ }
}
else
{
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/SignatureOptions.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/SignatureOptions.java?rev=1607514&r1=1607513&r2=1607514&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/SignatureOptions.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/SignatureOptions.java Thu Jul 3 01:47:50 2014
@@ -16,6 +16,7 @@
*/
package org.apache.pdfbox.pdmodel.interactive.digitalsignature;
+import java.io.Closeable;
import java.io.IOException;
import java.io.InputStream;
@@ -26,7 +27,7 @@ import org.apache.pdfbox.pdmodel.interac
/**
* TODO description needed
*/
-public class SignatureOptions
+public class SignatureOptions implements Closeable
{
private COSDocument visualSignature;
private int preferedSignatureSize;
@@ -64,7 +65,6 @@ public class SignatureOptions
* Reads the visual signature from the given input stream.
*
* @param is the input stream containing the visual signature
- *
* @throws IOException when something went wrong during parsing
*/
public void setVisualSignature(InputStream is) throws IOException
@@ -117,5 +117,18 @@ public class SignatureOptions
{
preferedSignatureSize = size;
}
- }
+ }
+
+ /**
+ * Closes the visual signature COSDocument, if any.
+ *
+ * @throws IOException if the document could not be closed
+ */
+ public void close() throws IOException
+ {
+ if (visualSignature != null)
+ {
+ visualSignature.close();
+ }
+ }
}