You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by "Roman Shaposhnik (JIRA)" <ji...@apache.org> on 2011/09/20 21:28:08 UTC

[jira] [Created] (BIGTOP-102) daemons need to be taken care of when packages are installed/upgraded/uninstalled

daemons need to be taken care of when packages are installed/upgraded/uninstalled
---------------------------------------------------------------------------------

                 Key: BIGTOP-102
                 URL: https://issues.apache.org/jira/browse/BIGTOP-102
             Project: Bigtop
          Issue Type: Bug
          Components: General
    Affects Versions: 0.1.0
            Reporter: Roman Shaposhnik
            Assignee: Roman Shaposhnik
             Fix For: 0.2.0


We need to make sure that all the packages that contain daemons/services exhibit the following behavior:
    * on installation they start (or don't start) the services depending on the defaults for the underlying OS
    * on upgrade services get restarted
    * on unistall services get shutdown

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BIGTOP-102) daemons need to be taken care of when packages are installed/upgraded/uninstalled

Posted by "Bruno Mahé (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BIGTOP-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109766#comment-13109766 ] 

Bruno Mahé commented on BIGTOP-102:
-----------------------------------

We should really start using revbiewboard for big patches at least.

+  force-reload|condrestart|try-restart)
+        is_oozie_alive
+        if [ ${STATUS} -eq 0 ] ; then
+          stop_oozie
+          start_oozie
+        fi
+        exit 0
+        ;;

=> Any reason to exit 0, but instead of reusing the status code of start_oozie (or the status of stop_oozie if it failed)




+	sed -e 's#@FLUME_DAEMON@#$@#g' $< > debian/flume-$@.init

=> Is creating/modifying files directly in debian/ ok in debian land? Or should we instread do that directly whet it is supposed to be installed?


+# Short-Description:    Cloudera Flume @FLUME_DAEMON@
=> It's Apache now :)


Other than that, seems reasonable to me

> daemons need to be taken care of when packages are installed/upgraded/uninstalled
> ---------------------------------------------------------------------------------
>
>                 Key: BIGTOP-102
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-102
>             Project: Bigtop
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 0.1.0
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>             Fix For: 0.2.0
>
>         Attachments: BIGTOP-102.patch.txt
>
>
> We need to make sure that all the packages that contain daemons/services exhibit the following behavior:
>     * on installation they start (or don't start) the services depending on the defaults for the underlying OS
>     * on upgrade services get restarted
>     * on unistall services get shutdown

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (BIGTOP-102) daemons need to be taken care of when packages are installed/upgraded/uninstalled

Posted by "Roman Shaposhnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BIGTOP-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109633#comment-13109633 ] 

Roman Shaposhnik commented on BIGTOP-102:
-----------------------------------------

For the ease of review, here's a GitHub branch comparison link: https://github.com/rvs/bigtop/compare/origin...trunk
   

> daemons need to be taken care of when packages are installed/upgraded/uninstalled
> ---------------------------------------------------------------------------------
>
>                 Key: BIGTOP-102
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-102
>             Project: Bigtop
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 0.1.0
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>             Fix For: 0.2.0
>
>         Attachments: BIGTOP-102.patch.txt
>
>
> We need to make sure that all the packages that contain daemons/services exhibit the following behavior:
>     * on installation they start (or don't start) the services depending on the defaults for the underlying OS
>     * on upgrade services get restarted
>     * on unistall services get shutdown

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BIGTOP-102) daemons need to be taken care of when packages are installed/upgraded/uninstalled

Posted by "Bruno Mahé (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BIGTOP-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108962#comment-13108962 ] 

Bruno Mahé commented on BIGTOP-102:
-----------------------------------

And even:
* (Un)Register their services (which is different from starting or not starting them) on install/removal

> daemons need to be taken care of when packages are installed/upgraded/uninstalled
> ---------------------------------------------------------------------------------
>
>                 Key: BIGTOP-102
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-102
>             Project: Bigtop
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 0.1.0
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>             Fix For: 0.2.0
>
>
> We need to make sure that all the packages that contain daemons/services exhibit the following behavior:
>     * on installation they start (or don't start) the services depending on the defaults for the underlying OS
>     * on upgrade services get restarted
>     * on unistall services get shutdown

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (BIGTOP-102) daemons need to be taken care of when packages are installed/upgraded/uninstalled

Posted by "Andrew Bayer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BIGTOP-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109639#comment-13109639 ] 

Andrew Bayer commented on BIGTOP-102:
-------------------------------------

All looks reasonable to me, but I really don't know what to look for, so probably should get looked over by someone who actually knows this stuff better. =)

> daemons need to be taken care of when packages are installed/upgraded/uninstalled
> ---------------------------------------------------------------------------------
>
>                 Key: BIGTOP-102
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-102
>             Project: Bigtop
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 0.1.0
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>             Fix For: 0.2.0
>
>         Attachments: BIGTOP-102.patch.txt
>
>
> We need to make sure that all the packages that contain daemons/services exhibit the following behavior:
>     * on installation they start (or don't start) the services depending on the defaults for the underlying OS
>     * on upgrade services get restarted
>     * on unistall services get shutdown

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BIGTOP-102) daemons need to be taken care of when packages are installed/upgraded/uninstalled

Posted by "Roman Shaposhnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BIGTOP-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109770#comment-13109770 ] 

Roman Shaposhnik commented on BIGTOP-102:
-----------------------------------------

Apache revbiewboard doesn't work out-of-the-box with Git repos :-( That's why I provided a GitHub diff url ;-) Did it not work for you?

As for the comments:
   1. good point, although elsewhere Oozie does exit 0 so we probably have to fix that too
   2. I think modifying files in deb is OK -- we need those files there for dh_installinit and that's the trick I've seen
   3. Cloudera Flume -> Apache Flume -- totally! good catch!



> daemons need to be taken care of when packages are installed/upgraded/uninstalled
> ---------------------------------------------------------------------------------
>
>                 Key: BIGTOP-102
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-102
>             Project: Bigtop
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 0.1.0
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>             Fix For: 0.2.0
>
>         Attachments: BIGTOP-102.patch.txt
>
>
> We need to make sure that all the packages that contain daemons/services exhibit the following behavior:
>     * on installation they start (or don't start) the services depending on the defaults for the underlying OS
>     * on upgrade services get restarted
>     * on unistall services get shutdown

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BIGTOP-102) daemons need to be taken care of when packages are installed/upgraded/uninstalled

Posted by "Roman Shaposhnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BIGTOP-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roman Shaposhnik updated BIGTOP-102:
------------------------------------

    Attachment: BIGTOP-102.patch.txt

> daemons need to be taken care of when packages are installed/upgraded/uninstalled
> ---------------------------------------------------------------------------------
>
>                 Key: BIGTOP-102
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-102
>             Project: Bigtop
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 0.1.0
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>             Fix For: 0.2.0
>
>         Attachments: BIGTOP-102.patch.txt
>
>
> We need to make sure that all the packages that contain daemons/services exhibit the following behavior:
>     * on installation they start (or don't start) the services depending on the defaults for the underlying OS
>     * on upgrade services get restarted
>     * on unistall services get shutdown

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira