You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/09/29 16:18:09 UTC
[GitHub] [hive] saihemanth-cloudera opened a new pull request #2684: HIVE-25570: Hive should send full URL path for authorization for comm…
saihemanth-cloudera opened a new pull request #2684:
URL: https://github.com/apache/hive/pull/2684
…and 'insert overwrite location'
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Made changes such that hive will now be sending full url path for authorization for the command insert overwrite location
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
Otherwise, hive is only sending the URI specified in the input command which isn't consistent with other commands like Create external table with directory (where we send full URL for authorization).
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No.
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Local machine, remote cluster
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] nrg4878 commented on pull request #2684: HIVE-25570: Hive should send full URL path for authorization for comm…
Posted by GitBox <gi...@apache.org>.
nrg4878 commented on pull request #2684:
URL: https://github.com/apache/hive/pull/2684#issuecomment-937996550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] nrg4878 commented on pull request #2684: HIVE-25570: Hive should send full URL path for authorization for comm…
Posted by GitBox <gi...@apache.org>.
nrg4878 commented on pull request #2684:
URL: https://github.com/apache/hive/pull/2684#issuecomment-930533618
Pending tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] saihemanth-cloudera closed pull request #2684: HIVE-25570: Hive should send full URL path for authorization for comm…
Posted by GitBox <gi...@apache.org>.
saihemanth-cloudera closed pull request #2684:
URL: https://github.com/apache/hive/pull/2684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] nrg4878 commented on pull request #2684: HIVE-25570: Hive should send full URL path for authorization for comm…
Posted by GitBox <gi...@apache.org>.
nrg4878 commented on pull request #2684:
URL: https://github.com/apache/hive/pull/2684#issuecomment-938002238
@pgaref I pushed the missing qfiles from the commit to master just now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] nrg4878 commented on pull request #2684: HIVE-25570: Hive should send full URL path for authorization for comm…
Posted by GitBox <gi...@apache.org>.
nrg4878 commented on pull request #2684:
URL: https://github.com/apache/hive/pull/2684#issuecomment-937996550
Let me take a look. Sorry for the trouble.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] nrg4878 commented on pull request #2684: HIVE-25570: Hive should send full URL path for authorization for comm…
Posted by GitBox <gi...@apache.org>.
nrg4878 commented on pull request #2684:
URL: https://github.com/apache/hive/pull/2684#issuecomment-930533618
Pending tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on pull request #2684: HIVE-25570: Hive should send full URL path for authorization for comm…
Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #2684:
URL: https://github.com/apache/hive/pull/2684#issuecomment-937646569
Hey @nrg4878 @saihemanth-cloudera there seems to be an issue with this commit on master: https://github.com/apache/hive/commit/a3d302ff7047898745bb556ebe8d2e1cb49549b2
Only SemanticAnalyzer.java changes where pushed and query.out files are missing -- this is currently breaking upstream tests, can you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on pull request #2684: HIVE-25570: Hive should send full URL path for authorization for comm…
Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #2684:
URL: https://github.com/apache/hive/pull/2684#issuecomment-937646569
Hey @nrg4878 @saihemanth-cloudera there seems to be an issue with this commit on master: https://github.com/apache/hive/commit/a3d302ff7047898745bb556ebe8d2e1cb49549b2
Only SemanticAnalyzer.java changes where pushed and query.out files are missing -- this is currently breaking upstream tests, can you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] nrg4878 commented on pull request #2684: HIVE-25570: Hive should send full URL path for authorization for comm…
Posted by GitBox <gi...@apache.org>.
nrg4878 commented on pull request #2684:
URL: https://github.com/apache/hive/pull/2684#issuecomment-935165762
Fix has been pushed to master. Please close the PR. Thank you @saihemanth-cloudera
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org