You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/05/08 12:11:44 UTC

[GitHub] [incubator-iceberg] waterlx opened a new pull request #1015: Support time type in GenericAvroReader and Writer

waterlx opened a new pull request #1015:
URL: https://github.com/apache/incubator-iceberg/pull/1015


   I found that GenericAvroReader and Writer do not support the logical type of "time-micros" of Avro, so that TimeType of Iceberg is not supported.
   Got the following exception:
   ```
   java.lang.IllegalArgumentException: Unsupported logical type: org.apache.iceberg.shaded.org.apache.avro.LogicalTypes$TimeMicros@6d2abe55
           at org.apache.iceberg.avro.GenericAvroWriter$WriteBuilder.primitive(GenericAvroWriter.java:108)
           at org.apache.iceberg.avro.GenericAvroWriter$WriteBuilder.primitive(GenericAvroWriter.java:49)
           at org.apache.iceberg.avro.AvroSchemaVisitor.visit(AvroSchemaVisitor.java:71)
           at org.apache.iceberg.avro.AvroSchemaVisitor.visit(AvroSchemaVisitor.java:56)
           at org.apache.iceberg.avro.AvroSchemaVisitor.visitWithName(AvroSchemaVisitor.java:85)
           at org.apache.iceberg.avro.AvroSchemaVisitor.visit(AvroSchemaVisitor.java:44)
           at org.apache.iceberg.avro.AvroSchemaVisitor.visitWithName(AvroSchemaVisitor.java:85)
           at org.apache.iceberg.avro.AvroSchemaVisitor.visit(AvroSchemaVisitor.java:44)
           at org.apache.iceberg.avro.AvroSchemaVisitor.visitWithName(AvroSchemaVisitor.java:85)
           at org.apache.iceberg.avro.AvroSchemaVisitor.visit(AvroSchemaVisitor.java:44)
           at org.apache.iceberg.avro.GenericAvroWriter.setSchema(GenericAvroWriter.java:41)
           at org.apache.iceberg.avro.GenericAvroWriter.<init>(GenericAvroWriter.java:35)
           at org.apache.iceberg.avro.AvroFileAppender.newAvroWriter(AvroFileAppender.java:88)
           at org.apache.iceberg.avro.AvroFileAppender.<init>(AvroFileAppender.java:45)
           at org.apache.iceberg.avro.Avro$WriteBuilder.build(Avro.java:163)
           at org.apache.iceberg.ManifestWriter$V1Writer.newAppender(ManifestWriter.java:234)
           at org.apache.iceberg.ManifestWriter.<init>(ManifestWriter.java:72)
           at org.apache.iceberg.ManifestWriter.<init>(ManifestWriter.java:32)
           at org.apache.iceberg.ManifestWriter$V1Writer.<init>(ManifestWriter.java:213)
           at org.apache.iceberg.ManifestFiles.write(ManifestFiles.java:89)
           at org.apache.iceberg.ManifestFiles.write(ManifestFiles.java:74)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [incubator-iceberg] waterlx commented on pull request #1015: Support time type in GenericAvroReader and Writer

Posted by GitBox <gi...@apache.org>.
waterlx commented on pull request #1015:
URL: https://github.com/apache/incubator-iceberg/pull/1015#issuecomment-625789601


   @rdblue Would you please reivew this small fix? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [incubator-iceberg] rdblue commented on pull request #1015: Support time type in GenericAvroReader and Writer

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1015:
URL: https://github.com/apache/incubator-iceberg/pull/1015#issuecomment-625892584


   Thanks, @waterlx! Could you add a test for this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org