You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/11/11 06:36:18 UTC

[GitHub] [submarine] charlie0220 opened a new pull request #451: Submarine 669

charlie0220 opened a new pull request #451:
URL: https://github.com/apache/submarine/pull/451


   ### What is this PR for?
   Fix the rule of "Notebook Name" while creating new notebook and add description in userdocs.
   Now notebook name should follow the DNS label standard as defined in RFC 1123.
   1. Contain at most 63 characters.
   2. Contain only lowercase alphanumeric characters or '-'.
   3. Start with an alphanumeric character.
   4. End with an alphanumeric character.
   
   ### What type of PR is it?
   [Bug Fix]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   [SUBMARINE-669](https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-669?filter=allopenissues)
   
   ### How should this be tested?
   [Travis CI](https://travis-ci.com/github/charlie0220/submarine/builds/199579036)
   
   ### Screenshots (if appropriate)
   ![screen-capture](https://user-images.githubusercontent.com/50860453/98776092-4aac5880-2429-11eb-902e-0df98bbc6ac3.gif)
   
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #451: SUBMARINE-669. Notebook name contain only lowercase alphanumeric characters or '-'

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #451:
URL: https://github.com/apache/submarine/pull/451


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] charlie0220 commented on pull request #451: SUBMARINE-669. Notebook name contain only lowercase alphanumeric characters or '-'

Posted by GitBox <gi...@apache.org>.
charlie0220 commented on pull request #451:
URL: https://github.com/apache/submarine/pull/451#issuecomment-728785887


   I found out a problem. Please do not merge this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] lowc1012 commented on pull request #451: SUBMARINE-669. Notebook name contain only lowercase alphanumeric characters or '-'

Posted by GitBox <gi...@apache.org>.
lowc1012 commented on pull request #451:
URL: https://github.com/apache/submarine/pull/451#issuecomment-725882187


   @charlie0220 @kobe860219 
   Would it be better if we display validation message under the input field?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] lowc1012 commented on pull request #451: SUBMARINE-669. Notebook name contain only lowercase alphanumeric characters or '-'

Posted by GitBox <gi...@apache.org>.
lowc1012 commented on pull request #451:
URL: https://github.com/apache/submarine/pull/451#issuecomment-725806353


   @charlie0220 Thanks for your contribution!
   @kobe860219 Could you please help me review this PR ?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] kobe860219 commented on pull request #451: SUBMARINE-669. Notebook name contain only lowercase alphanumeric characters or '-'

Posted by GitBox <gi...@apache.org>.
kobe860219 commented on pull request #451:
URL: https://github.com/apache/submarine/pull/451#issuecomment-726019217


   @lowc1012 @charlie0220  I will embed ng-zorro to notebook page soon!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org