You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by David Reid <dr...@jetnet.co.uk> on 2000/06/20 10:59:38 UTC
Re: cvs commit: apache-2.0/src/main mpm_common.c
If people don't mind having the file included then sure, no problem. I just
figured most platforms don't need the file included and so I'd not just
blindly include extra header files.
david
----- Original Message -----
From: "Jeff Trawick" <tr...@ibm.net>
To: <ap...@apache.org>
Sent: Monday, June 19, 2000 10:14 PM
Subject: Re: cvs commit: apache-2.0/src/main mpm_common.c
> > From: dreid@locus.apache.org
> > Date: 19 Jun 2000 21:11:50 -0000
> >
> > dreid 00/06/19 14:11:50
> >
> > Modified: src/main mpm_common.c
> > Log:
> > Update mpm_common to work with the latest BeOS version and start
> > adding support for a new BeOS MPM that I'll commit in a few days.
> >
> > Revision Changes Path
> > 1.13 +4 -1 apache-2.0/src/main/mpm_common.c
> >
> > Index: mpm_common.c
> > ===================================================================
> > RCS file: /home/cvs/apache-2.0/src/main/mpm_common.c,v
> > retrieving revision 1.12
> > retrieving revision 1.13
> > diff -u -r1.12 -r1.13
> > --- mpm_common.c 2000/06/14 13:50:40 1.12
> > +++ mpm_common.c 2000/06/19 21:11:49 1.13
> > @@ -77,8 +77,11 @@
> > #if HAVE_SYS_TIME_H
> > #include <sys/time.h> /* for timeval definitions */
> > #endif
> > +#ifdef BEOS_BONE
> > +#include <sys/socket.h>
> > +#endif
>
> Why not #ifdef HAVE_SYS_SOCKET_H?
>
> --
> Jeff Trawick | trawick@ibm.net | PGP public key at web site:
> http://www.geocities.com/SiliconValley/Park/9289/
> Born in Roswell... married an alien...
>
Re: cvs commit: apache-2.0/src/main mpm_common.c
Posted by Jeff Trawick <tr...@ibm.net>.
> From: "David Reid" <dr...@jetnet.co.uk>
> Date: Tue, 20 Jun 2000 09:59:38 +0100
>
> If people don't mind having the file included then sure, no problem. I just
> figured most platforms don't need the file included and so I'd not just
> blindly include extra header files.
>
> david
I'd rather see the feature test than the platform test. If some
platform has the unexpected requirement that sys/time must be included
before sys/resource (FreeBSD!), I'll put the feature test around
sys/time. We are paying that negligible price all over the place. In
return, we expect a bit less trouble taking the code to a new
platform, which will share some of its idiosyncrasies with platforms
already handled. (But you already knew that.)
--
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
http://www.geocities.com/SiliconValley/Park/9289/
Born in Roswell... married an alien...