You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/11/08 05:53:34 UTC
[GitHub] [accumulo] ctubbsii opened a new pull request, #3071: Inline unneeded workaround in ClientContext
ctubbsii opened a new pull request, #3071:
URL: https://github.com/apache/accumulo/pull/3071
This removes an unneeded static `memoizeWithExpiration` method that existed solely to avoid a warning from the modernizer-maven-plugin. This change does not trigger that warning, and allows us to call Suppliers.memoizeWithExpiration directly, rather than through a proxy method. Additionally, this makes each of the three calls to this method independent of each other, so if it makes sense to tweak the expiration period for each of them, that can now be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #3071: Inline unneeded workaround in ClientContext
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on PR #3071:
URL: https://github.com/apache/accumulo/pull/3071#issuecomment-1306708036
@keith-turner You added the original method to get around a modernizer issue. Does this patch work for you? I could not reproduce any modernizer failures after applying these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii merged pull request #3071: Inline unneeded workaround in ClientContext
Posted by GitBox <gi...@apache.org>.
ctubbsii merged PR #3071:
URL: https://github.com/apache/accumulo/pull/3071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on pull request #3071: Inline unneeded workaround in ClientContext
Posted by GitBox <gi...@apache.org>.
keith-turner commented on PR #3071:
URL: https://github.com/apache/accumulo/pull/3071#issuecomment-1307066793
> @keith-turner You added the original method to get around a modernizer issue. Does this patch work for you?
Yeah it looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org