You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/09/02 21:31:17 UTC
Re: Review Request 37170: Maintenance Primitives: Added `Machine` to
Slave struct in Master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37170/
-----------------------------------------------------------
(Updated Sept. 2, 2015, 7:31 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b
src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
Diff: https://reviews.apache.org/r/37170/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37170: Maintenance Primitives: Added `Machine` to
Slave struct in Master.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37170/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 12:11 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Changes
-------
Removed new-line.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/Makefile.am 8963cea9fd7e3bee450a1059e6383e5ab868a17b
src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
src/master/machine.hpp PRE-CREATION
src/master/maintenance.hpp bebaeb24efbd58df38796e3941f36a21791b6bfd
src/master/maintenance.cpp 277dd8270fbd497616e5b24db4ea7dd615e170e3
src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24
src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
Diff: https://reviews.apache.org/r/37170/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37170: Maintenance Primitives: Added `Machine` to
Slave struct in Master.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37170/#review98794
-----------------------------------------------------------
Ship it!
Looks great!
src/master/master.cpp (line 3950)
<https://reviews.apache.org/r/37170/#comment155395>
Kill newline?
- Benjamin Hindman
On Sept. 13, 2015, 8:32 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37170/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2015, 8:32 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 8963cea9fd7e3bee450a1059e6383e5ab868a17b
> src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
> src/master/machine.hpp PRE-CREATION
> src/master/maintenance.hpp bebaeb24efbd58df38796e3941f36a21791b6bfd
> src/master/maintenance.cpp 277dd8270fbd497616e5b24db4ea7dd615e170e3
> src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24
> src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
>
> Diff: https://reviews.apache.org/r/37170/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37170: Maintenance Primitives: Added `Machine` to
Slave struct in Master.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37170/
-----------------------------------------------------------
(Updated Sept. 13, 2015, 8:32 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/Makefile.am 8963cea9fd7e3bee450a1059e6383e5ab868a17b
src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
src/master/machine.hpp PRE-CREATION
src/master/maintenance.hpp bebaeb24efbd58df38796e3941f36a21791b6bfd
src/master/maintenance.cpp 277dd8270fbd497616e5b24db4ea7dd615e170e3
src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24
src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
Diff: https://reviews.apache.org/r/37170/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37170: Maintenance Primitives: Added `Machine` to
Slave struct in Master.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37170/#review97520
-----------------------------------------------------------
Ship it!
LGTM!
src/master/master.cpp (lines 1367 - 1369)
<https://reviews.apache.org/r/37170/#comment153469>
Do we want to modify the registry operations to include this information? (On the add/remove slave operations.)
- Joseph Wu
On Sept. 2, 2015, 12:31 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37170/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 12:31 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
> src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b
> src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
>
> Diff: https://reviews.apache.org/r/37170/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>