You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/23 08:02:05 UTC

[GitHub] [flink] kl0u edited a comment on issue #10653: [FLINK-13027][streaming]: StreamingFileSink bulk-encoded writer supports customized checkpoint policy

kl0u edited a comment on issue #10653: [FLINK-13027][streaming]: StreamingFileSink bulk-encoded writer supports customized checkpoint policy
URL: https://github.com/apache/flink/pull/10653#issuecomment-568381500
 
 
   Hi @yxu-valleytider , thanks for the PR. 
   
   I am on holidays, so I do not think I will have time to give it a thorough review but from a first look, I think that the `FSizeCheckpointRollingPolicy` is a specific implementation of a `CheckpointRollingPolicy `. So, given that we add the latter, I do not think we should add the `FSizeCheckpointRollingPolicy` to the master. I do not think we need to provide that many pre-implemented rolling policies and the interface is pretty simple.
   
   In addition, given that this PR introduces a new feature, you should also update the documentation section of the `StreamingFileSink`.
   
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services