You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by xiang li <wa...@gmail.com> on 2014/07/15 05:09:32 UTC
Review Request 23475: Review request for FLUME-1793,
a new patch to use GSON to make assertions ignore ordering
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23475/
-----------------------------------------------------------
Review request for Flume.
Bugs: FLUME-1793
https://issues.apache.org/jira/browse/FLUME-1793
Repository: flume-git
Description
-------
The following 4 trivial changes are included into the test case.
1. For testRoundTrip()
(1) Use GSON, to make assertion ignore ordering
(2) Add indents when building the expected result, to improve the readability, no logic is changed
2. For shouldHandleInvalidJSONDuringComplexParsing()
(1) Use GSON, to make assertion ignore ordering
(2) Add indents when building the expected result, to improve the readability, no logic is changed
Diffs
-----
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchLogStashEventSerializer.java d2c9543
Diff: https://reviews.apache.org/r/23475/diff/
Testing
-------
This is a test case change. Tested it using Oracle and IBM JDK, covering both 1.6 and 1.7
Thanks,
xiang li
Re: Review Request 23475: Review request for FLUME-1793,
a new patch to use GSON to make assertions ignore ordering
Posted by Edward Sargisson <es...@pobox.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23475/#review47779
-----------------------------------------------------------
This is good stuff; nice and tidy. I think comparing the Json based on the resulting AST is a good approach.
Let's ship it unchanged.
- Edward Sargisson
On July 14, 2014, 8:09 p.m., xiang li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23475/
> -----------------------------------------------------------
>
> (Updated July 14, 2014, 8:09 p.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-1793
> https://issues.apache.org/jira/browse/FLUME-1793
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> The following 4 trivial changes are included into the test case.
> 1. For testRoundTrip()
> (1) Use GSON, to make assertion ignore ordering
> (2) Add indents when building the expected result, to improve the readability, no logic is changed
> 2. For shouldHandleInvalidJSONDuringComplexParsing()
> (1) Use GSON, to make assertion ignore ordering
> (2) Add indents when building the expected result, to improve the readability, no logic is changed
>
>
> Diffs
> -----
>
> flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchLogStashEventSerializer.java d2c9543
>
> Diff: https://reviews.apache.org/r/23475/diff/
>
>
> Testing
> -------
>
> This is a test case change. Tested it using Oracle and IBM JDK, covering both 1.6 and 1.7
>
>
> Thanks,
>
> xiang li
>
>