You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Sebastien <se...@gmail.com> on 2017/03/12 19:51:23 UTC
8.0.0-M4: org.json has issue with List
Hi devs,
The new underlying json library (open-json from tdunning) does not convert
List properly (there are converted to String) [1]
I didn't have seen where in Wicket we are returning a converted List in a
json response, but I prefer you are aware :)
Best regards,
Sebastien.
[1] https://github.com/tdunning/open-json/issues/12
Re: 8.0.0-M4: org.json has issue with List
Posted by Tobias Soloschenko <to...@googlemail.com>.
Thanks a lot for those fixes - I didn't had the time to take care of them!
I am happy that the issues are solved, now.
kind regards
Tobias
> Am 13.03.2017 um 22:02 schrieb Sebastien <se...@gmail.com>:
>
> Hi Martin,
>
> Thanks a lot for the quick update! From what I can see it seems to be good!
> :)
>
> Best regards,
> Sebastien
>
> On Mon, Mar 13, 2017 at 9:10 PM, Martin Grigorov <mg...@apache.org>
> wrote:
>
>> Hi Sebastien,
>>
>> As you may have noticed I've updated the version of OpenJson to 1.0.1 with
>> the fix by Mikhail.
>> I'll check whether something has to be done for 6.x and 7.x tomorrow.
>>
>> Martin Grigorov
>> Wicket Training and Consulting
>> https://twitter.com/mtgrigorov
>>
>> On Mon, Mar 13, 2017 at 10:04 AM, Martin Grigorov <mg...@apache.org>
>> wrote:
>>
>>> Hi,
>>>
>>> Since recently [1] in 8.x we now use the fork with improvements at
>>> https://github.com/openjson/openjson
>>> Ted Dunning's impl fails badly if the original org.json library is needed
>>> as transitive dependency.
>>>
>>> IMO we should update the copies in 6.x/7.x with the classes from
>>> https://github.com/openjson/openjson as well. To keep 6.x, 7.x and 8.x
>> as
>>> close as possible.
>>>
>>> 1. https://issues.apache.org/jira/browse/WICKET-6329
>>>
>>> Martin Grigorov
>>> Wicket Training and Consulting
>>> https://twitter.com/mtgrigorov
>>>
>>>> On Sun, Mar 12, 2017 at 8:51 PM, Sebastien <se...@gmail.com> wrote:
>>>>
>>>> Hi devs,
>>>>
>>>> The new underlying json library (open-json from tdunning) does not
>> convert
>>>> List properly (there are converted to String) [1]
>>>>
>>>> I didn't have seen where in Wicket we are returning a converted List in
>> a
>>>> json response, but I prefer you are aware :)
>>>>
>>>> Best regards,
>>>> Sebastien.
>>>>
>>>> [1] https://github.com/tdunning/open-json/issues/12
>>>>
>>>
>>>
>>
Re: 8.0.0-M4: org.json has issue with List
Posted by Sebastien <se...@gmail.com>.
Hi Martin,
Thanks a lot for the quick update! From what I can see it seems to be good!
:)
Best regards,
Sebastien
On Mon, Mar 13, 2017 at 9:10 PM, Martin Grigorov <mg...@apache.org>
wrote:
> Hi Sebastien,
>
> As you may have noticed I've updated the version of OpenJson to 1.0.1 with
> the fix by Mikhail.
> I'll check whether something has to be done for 6.x and 7.x tomorrow.
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Mon, Mar 13, 2017 at 10:04 AM, Martin Grigorov <mg...@apache.org>
> wrote:
>
> > Hi,
> >
> > Since recently [1] in 8.x we now use the fork with improvements at
> > https://github.com/openjson/openjson
> > Ted Dunning's impl fails badly if the original org.json library is needed
> > as transitive dependency.
> >
> > IMO we should update the copies in 6.x/7.x with the classes from
> > https://github.com/openjson/openjson as well. To keep 6.x, 7.x and 8.x
> as
> > close as possible.
> >
> > 1. https://issues.apache.org/jira/browse/WICKET-6329
> >
> > Martin Grigorov
> > Wicket Training and Consulting
> > https://twitter.com/mtgrigorov
> >
> > On Sun, Mar 12, 2017 at 8:51 PM, Sebastien <se...@gmail.com> wrote:
> >
> >> Hi devs,
> >>
> >> The new underlying json library (open-json from tdunning) does not
> convert
> >> List properly (there are converted to String) [1]
> >>
> >> I didn't have seen where in Wicket we are returning a converted List in
> a
> >> json response, but I prefer you are aware :)
> >>
> >> Best regards,
> >> Sebastien.
> >>
> >> [1] https://github.com/tdunning/open-json/issues/12
> >>
> >
> >
>
Re: 8.0.0-M4: org.json has issue with List
Posted by Martin Grigorov <mg...@apache.org>.
Hi Sebastien,
As you may have noticed I've updated the version of OpenJson to 1.0.1 with
the fix by Mikhail.
I'll check whether something has to be done for 6.x and 7.x tomorrow.
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Mon, Mar 13, 2017 at 10:04 AM, Martin Grigorov <mg...@apache.org>
wrote:
> Hi,
>
> Since recently [1] in 8.x we now use the fork with improvements at
> https://github.com/openjson/openjson
> Ted Dunning's impl fails badly if the original org.json library is needed
> as transitive dependency.
>
> IMO we should update the copies in 6.x/7.x with the classes from
> https://github.com/openjson/openjson as well. To keep 6.x, 7.x and 8.x as
> close as possible.
>
> 1. https://issues.apache.org/jira/browse/WICKET-6329
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Sun, Mar 12, 2017 at 8:51 PM, Sebastien <se...@gmail.com> wrote:
>
>> Hi devs,
>>
>> The new underlying json library (open-json from tdunning) does not convert
>> List properly (there are converted to String) [1]
>>
>> I didn't have seen where in Wicket we are returning a converted List in a
>> json response, but I prefer you are aware :)
>>
>> Best regards,
>> Sebastien.
>>
>> [1] https://github.com/tdunning/open-json/issues/12
>>
>
>
Re: 8.0.0-M4: org.json has issue with List
Posted by Martin Grigorov <mg...@apache.org>.
Hi,
Since recently [1] in 8.x we now use the fork with improvements at
https://github.com/openjson/openjson
Ted Dunning's impl fails badly if the original org.json library is needed
as transitive dependency.
IMO we should update the copies in 6.x/7.x with the classes from
https://github.com/openjson/openjson as well. To keep 6.x, 7.x and 8.x as
close as possible.
1. https://issues.apache.org/jira/browse/WICKET-6329
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Sun, Mar 12, 2017 at 8:51 PM, Sebastien <se...@gmail.com> wrote:
> Hi devs,
>
> The new underlying json library (open-json from tdunning) does not convert
> List properly (there are converted to String) [1]
>
> I didn't have seen where in Wicket we are returning a converted List in a
> json response, but I prefer you are aware :)
>
> Best regards,
> Sebastien.
>
> [1] https://github.com/tdunning/open-json/issues/12
>