You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/03/10 08:19:54 UTC
[GitHub] [rocketmq-client-go] jasondeng1997 opened a new pull request #785: add imports-formatter
jasondeng1997 opened a new pull request #785:
URL: https://github.com/apache/rocketmq-client-go/pull/785
## What is the purpose of the change
imports-formatter will split illegal format imports to three blocks:
the first import block is some built-in modules/packages in go language.
the second import block is some third party modules/packages.
the third import block is the modules/packages in this module.
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] jasondeng1997 commented on pull request #785: add imports-formatter
Posted by GitBox <gi...@apache.org>.
jasondeng1997 commented on pull request #785:
URL: https://github.com/apache/rocketmq-client-go/pull/785#issuecomment-1063839851
用的是dubbogo 的go工具包
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] jasondeng1997 commented on pull request #785: add imports-formatter
Posted by GitBox <gi...@apache.org>.
jasondeng1997 commented on pull request #785:
URL: https://github.com/apache/rocketmq-client-go/pull/785#issuecomment-1063793082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] jasondeng1997 commented on pull request #785: add imports-formatter
Posted by GitBox <gi...@apache.org>.
jasondeng1997 commented on pull request #785:
URL: https://github.com/apache/rocketmq-client-go/pull/785#issuecomment-1063792342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] jasondeng1997 commented on pull request #785: add imports-formatter
Posted by GitBox <gi...@apache.org>.
jasondeng1997 commented on pull request #785:
URL: https://github.com/apache/rocketmq-client-go/pull/785#issuecomment-1063793359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] jasondeng1997 commented on pull request #785: add imports-formatter
Posted by GitBox <gi...@apache.org>.
jasondeng1997 commented on pull request #785:
URL: https://github.com/apache/rocketmq-client-go/pull/785#issuecomment-1063794993
区分go包，自己包，引用其他的包
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] jasondeng1997 closed pull request #785: add imports-formatter
Posted by GitBox <gi...@apache.org>.
jasondeng1997 closed pull request #785:
URL: https://github.com/apache/rocketmq-client-go/pull/785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] jasondeng1997 removed a comment on pull request #785: add imports-formatter
Posted by GitBox <gi...@apache.org>.
jasondeng1997 removed a comment on pull request #785:
URL: https://github.com/apache/rocketmq-client-go/pull/785#issuecomment-1063793359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org