You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2021/02/18 10:00:16 UTC

[GitHub] [thrift] Jens-G commented on a change in pull request #2333: Cherry picks for 0.14.0 branch

Jens-G commented on a change in pull request #2333:
URL: https://github.com/apache/thrift/pull/2333#discussion_r578282547



##########
File path: test/ThriftTest.thrift
##########
@@ -411,3 +411,17 @@ struct StructB {
 struct OptionalSetDefaultTest {
   1: optional set<string> with_default = [ "test" ]
 }
+
+service ConflictingNamesTest {

Review comment:
       The ThriftTest.thrift file serves a very specific purpose: It is the base for the cross language Test Suite. 
   Adding unrelated tests in that file is highly discouraged.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org