You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jmeter.apache.org by "FSchumacher (via GitHub)" <gi...@apache.org> on 2023/04/22 10:36:47 UTC

[GitHub] [jmeter] FSchumacher commented on pull request #5812: Bug #5807 - Fix an ArrayIndexOutOfBoundsException on HTTP parameters …

FSchumacher commented on PR #5812:
URL: https://github.com/apache/jmeter/pull/5812#issuecomment-1518594464

   Looks good to me.
   
   Why did you place the parametrized test in its own test class?
   
   Instead of re-opening a new PR for each round, you could have pushed to the first PR you opened. That way, the comments on the PR would have been together in one PR.
   
   Not really related to this PR: Line 305 (new counting) in the old code is weird. `paramSplit.length` will never be `1`, if there is an `=` sign in the splitted param and it is not the sole char of that param. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org