You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2020/04/22 13:18:47 UTC

[GitHub] [brooklyn-server] iuliana commented on a change in pull request #1090: WIP: Upgrade kubernetes-client to 4.9.0 to support AWS command to get OauthToken

iuliana commented on a change in pull request #1090:
URL: https://github.com/apache/brooklyn-server/pull/1090#discussion_r412974298



##########
File path: locations/container/src/main/java/org/apache/brooklyn/container/location/kubernetes/KubernetesLocation.java
##########
@@ -186,13 +185,36 @@ public KubernetesMachineLocation obtain(Map<?, ?> flags) {
     @Override
     public void release(KubernetesMachineLocation machine) {
         Entity entity = validateCallerContext(machine);
+        reinitClientIfExpired(entity);

Review comment:
       Yes, that would make sense, the reason I kept it here for now is because I need the entity to get the namespace. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org