You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Fatima Khan <fa...@gmail.com> on 2017/08/16 14:04:00 UTC
Re: Review Request 61691: RANGER-1736 : Good coding practice in Ranger
recommended by static code analysis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61691/
-----------------------------------------------------------
(Updated Aug. 16, 2017, 2:03 p.m.)
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Summary (updated)
-----------------
RANGER-1736 : Good coding practice in Ranger recommended by static code analysis
Bugs: RANGER-1736
https://issues.apache.org/jira/browse/RANGER-1736
Repository: ranger
Description
-------
Good coding practice in Ranger recommended by static code analysis on
1.UserMgr.java
2.XUserMgr.java
3.TestXUserMgr.java
4.LdapPolicyMgrUserGroupBuilder.java
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java c1145e7
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 5a5335a
security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 601af14
ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java c39cc57
Diff: https://reviews.apache.org/r/61691/diff/1/
Testing
-------
1.Verified when ranger-admin connect to LDAP server than users are synchronised form there they got same role which is specified in usersync-side.
2.Verified unix authentication and usersync.
3.Junit test was successful
Thanks,
Fatima Khan
Re: Review Request 61691: RANGER-1736 : Good coding practice in Ranger
recommended by static code analysis
Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61691/#review183553
-----------------------------------------------------------
Ship it!
Ship It!
- Sailaja Polavarapu
On Aug. 16, 2017, 2:03 p.m., Fatima Khan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61691/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2017, 2:03 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1736
> https://issues.apache.org/jira/browse/RANGER-1736
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Good coding practice in Ranger recommended by static code analysis on
> 1.UserMgr.java
> 2.XUserMgr.java
> 3.TestXUserMgr.java
> 4.LdapPolicyMgrUserGroupBuilder.java
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java c1145e7
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 5a5335a
> security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 601af14
> ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java c39cc57
>
>
> Diff: https://reviews.apache.org/r/61691/diff/1/
>
>
> Testing
> -------
>
> 1.Verified when ranger-admin connect to LDAP server than users are synchronised form there they got same role which is specified in usersync-side.
> 2.Verified unix authentication and usersync.
> 3.Junit test was successful
>
>
> Thanks,
>
> Fatima Khan
>
>
Re: Review Request 61691: RANGER-1736 : Good coding practice in Ranger
recommended by static code analysis
Posted by Ankita Sinha <an...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61691/#review183575
-----------------------------------------------------------
Ship it!
Ship It!
- Ankita Sinha
On Aug. 16, 2017, 2:03 p.m., Fatima Khan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61691/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2017, 2:03 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1736
> https://issues.apache.org/jira/browse/RANGER-1736
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Good coding practice in Ranger recommended by static code analysis on
> 1.UserMgr.java
> 2.XUserMgr.java
> 3.TestXUserMgr.java
> 4.LdapPolicyMgrUserGroupBuilder.java
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java c1145e7
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 5a5335a
> security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 601af14
> ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java c39cc57
>
>
> Diff: https://reviews.apache.org/r/61691/diff/1/
>
>
> Testing
> -------
>
> 1.Verified when ranger-admin connect to LDAP server than users are synchronised form there they got same role which is specified in usersync-side.
> 2.Verified unix authentication and usersync.
> 3.Junit test was successful
>
>
> Thanks,
>
> Fatima Khan
>
>