You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erick Erickson (Created) (JIRA)" <ji...@apache.org> on 2011/11/07 19:20:52 UTC
[jira] [Created] (SOLR-2881) Trie fields should support
sortMissingLast="true"
Trie fields should support sortMissingLast="true"
-------------------------------------------------
Key: SOLR-2881
URL: https://issues.apache.org/jira/browse/SOLR-2881
Project: Solr
Issue Type: Improvement
Components: Schema and Analysis
Affects Versions: 3.5, 4.0
Environment: All
Reporter: Erick Erickson
Fix For: 3.5, 4.0
Spinoff from SOLR-2134. The consensus is that the way sortMissingFirst is done in 3x is superior to 4x and when that is done (see LUCENE-3443) then the sortMissingFirst code should be incorporated into both.
As of now, however, the Trie fields in 4.0 support sortMissingFirst but not yet in 3.x
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-2881) Trie fields should support
sortMissingLast="true"
Posted by "Erick Erickson (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson resolved SOLR-2881.
----------------------------------
Resolution: Fixed
Even credited Uwe in the CHANGES.txt file.
> Trie fields should support sortMissingLast="true"
> -------------------------------------------------
>
> Key: SOLR-2881
> URL: https://issues.apache.org/jira/browse/SOLR-2881
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
> Affects Versions: 3.5, 4.0
> Environment: All
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Fix For: 3.5, 4.0
>
> Attachments: SOLR-2881-3x.patch, SOLR-2881.patch
>
>
> Spinoff from SOLR-2134. The consensus is that the way sortMissingFirst is done in 3x is superior to 4x and when that is done (see LUCENE-3443) then the sortMissingFirst code should be incorporated into both.
> As of now, however, the Trie fields in 4.0 support sortMissingFirst but not yet in 3.x
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2881) Trie fields should support
sortMissingLast="true"
Posted by "Simon Willnauer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150427#comment-13150427 ]
Simon Willnauer commented on SOLR-2881:
---------------------------------------
I just moved the changes entry to the trunk changes file too. Erick we need to try to keep them in sync
> Trie fields should support sortMissingLast="true"
> -------------------------------------------------
>
> Key: SOLR-2881
> URL: https://issues.apache.org/jira/browse/SOLR-2881
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
> Affects Versions: 3.5, 4.0
> Environment: All
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Fix For: 3.5, 4.0
>
> Attachments: SOLR-2881-3x.patch, SOLR-2881.patch
>
>
> Spinoff from SOLR-2134. The consensus is that the way sortMissingFirst is done in 3x is superior to 4x and when that is done (see LUCENE-3443) then the sortMissingFirst code should be incorporated into both.
> As of now, however, the Trie fields in 4.0 support sortMissingFirst but not yet in 3.x
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2881) Trie fields should support
sortMissingLast="true"
Posted by "Erick Erickson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150456#comment-13150456 ]
Erick Erickson commented on SOLR-2881:
--------------------------------------
Thanks Simon, now I've learned yet another bit on how things work...
> Trie fields should support sortMissingLast="true"
> -------------------------------------------------
>
> Key: SOLR-2881
> URL: https://issues.apache.org/jira/browse/SOLR-2881
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
> Affects Versions: 3.5, 4.0
> Environment: All
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Fix For: 3.5, 4.0
>
> Attachments: SOLR-2881-3x.patch, SOLR-2881.patch
>
>
> Spinoff from SOLR-2134. The consensus is that the way sortMissingFirst is done in 3x is superior to 4x and when that is done (see LUCENE-3443) then the sortMissingFirst code should be incorporated into both.
> As of now, however, the Trie fields in 4.0 support sortMissingFirst but not yet in 3.x
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2881) Trie fields should support
sortMissingLast="true"
Posted by "Erick Erickson (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson updated SOLR-2881:
---------------------------------
Attachment: SOLR-2881.patch
SOLR-2134 fixes this issue for 4.x, this patch applies only to the 3x branch
> Trie fields should support sortMissingLast="true"
> -------------------------------------------------
>
> Key: SOLR-2881
> URL: https://issues.apache.org/jira/browse/SOLR-2881
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
> Affects Versions: 3.5, 4.0
> Environment: All
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Fix For: 3.5, 4.0
>
> Attachments: SOLR-2881-3x.patch, SOLR-2881.patch
>
>
> Spinoff from SOLR-2134. The consensus is that the way sortMissingFirst is done in 3x is superior to 4x and when that is done (see LUCENE-3443) then the sortMissingFirst code should be incorporated into both.
> As of now, however, the Trie fields in 4.0 support sortMissingFirst but not yet in 3.x
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2881) Trie fields should support
sortMissingLast="true"
Posted by "Erick Erickson (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson updated SOLR-2881:
---------------------------------
Attachment: SOLR-2881-3x.patch
I think this is ready to commit if we clear one thing up. Look at the tests and you'll see that default sorting for dates is a special case. The sorting behavior for dates is, indeed, different from longs when sortMissingFirst/Last are not specified. The behavior is consistent with 3.3 (it was handy to test 3.3 rather than 3.4) however, so neither LUCENE-3443 nor this patch change sorting in this case.
I'd like to commit this tomorrow (Sunday). Since the reconciliation process is a bit "interesting" between Mike's and my changes, I think that a patch for each is preferable, but we know I'm "merge challenged".
Note also that Mike, as part of 3441, made the parallel set of changes for 4.x already. That said, I'm going to create a small 4.x patch that changes the example schema.xml and incorporates the date test from this patch. I'll attach that file to SOLR-2134
> Trie fields should support sortMissingLast="true"
> -------------------------------------------------
>
> Key: SOLR-2881
> URL: https://issues.apache.org/jira/browse/SOLR-2881
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
> Affects Versions: 3.5, 4.0
> Environment: All
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Fix For: 3.5, 4.0
>
> Attachments: SOLR-2881-3x.patch
>
>
> Spinoff from SOLR-2134. The consensus is that the way sortMissingFirst is done in 3x is superior to 4x and when that is done (see LUCENE-3443) then the sortMissingFirst code should be incorporated into both.
> As of now, however, the Trie fields in 4.0 support sortMissingFirst but not yet in 3.x
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2881) Trie fields should support
sortMissingLast="true"
Posted by "Erick Erickson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149184#comment-13149184 ]
Erick Erickson commented on SOLR-2881:
--------------------------------------
"Note also that Mike, as part of 3441" should have been "Note also that Mike, as part of LUCENE-3443"
> Trie fields should support sortMissingLast="true"
> -------------------------------------------------
>
> Key: SOLR-2881
> URL: https://issues.apache.org/jira/browse/SOLR-2881
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
> Affects Versions: 3.5, 4.0
> Environment: All
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Fix For: 3.5, 4.0
>
> Attachments: SOLR-2881-3x.patch
>
>
> Spinoff from SOLR-2134. The consensus is that the way sortMissingFirst is done in 3x is superior to 4x and when that is done (see LUCENE-3443) then the sortMissingFirst code should be incorporated into both.
> As of now, however, the Trie fields in 4.0 support sortMissingFirst but not yet in 3.x
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Assigned] (SOLR-2881) Trie fields should support
sortMissingLast="true"
Posted by "Erick Erickson (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson reassigned SOLR-2881:
------------------------------------
Assignee: Erick Erickson
> Trie fields should support sortMissingLast="true"
> -------------------------------------------------
>
> Key: SOLR-2881
> URL: https://issues.apache.org/jira/browse/SOLR-2881
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
> Affects Versions: 3.5, 4.0
> Environment: All
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Fix For: 3.5, 4.0
>
>
> Spinoff from SOLR-2134. The consensus is that the way sortMissingFirst is done in 3x is superior to 4x and when that is done (see LUCENE-3443) then the sortMissingFirst code should be incorporated into both.
> As of now, however, the Trie fields in 4.0 support sortMissingFirst but not yet in 3.x
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2881) Trie fields should support
sortMissingLast="true"
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149190#comment-13149190 ]
Uwe Schindler commented on SOLR-2881:
-------------------------------------
Hey, I also want to be listed in changes.txt as I did the new Lucene API with its sophisticated v2==0 and super.setNextReader logic :-)
Otherwise, looks fine!
> Trie fields should support sortMissingLast="true"
> -------------------------------------------------
>
> Key: SOLR-2881
> URL: https://issues.apache.org/jira/browse/SOLR-2881
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
> Affects Versions: 3.5, 4.0
> Environment: All
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Fix For: 3.5, 4.0
>
> Attachments: SOLR-2881-3x.patch
>
>
> Spinoff from SOLR-2134. The consensus is that the way sortMissingFirst is done in 3x is superior to 4x and when that is done (see LUCENE-3443) then the sortMissingFirst code should be incorporated into both.
> As of now, however, the Trie fields in 4.0 support sortMissingFirst but not yet in 3.x
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2881) Trie fields should support
sortMissingLast="true"
Posted by "Michael McCandless (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149122#comment-13149122 ]
Michael McCandless commented on SOLR-2881:
------------------------------------------
OK I committed the missing "it's not insane if a field has both Bits and array entries" -- just missed this on backport for LUCENE-3443.
> Trie fields should support sortMissingLast="true"
> -------------------------------------------------
>
> Key: SOLR-2881
> URL: https://issues.apache.org/jira/browse/SOLR-2881
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
> Affects Versions: 3.5, 4.0
> Environment: All
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Fix For: 3.5, 4.0
>
>
> Spinoff from SOLR-2134. The consensus is that the way sortMissingFirst is done in 3x is superior to 4x and when that is done (see LUCENE-3443) then the sortMissingFirst code should be incorporated into both.
> As of now, however, the Trie fields in 4.0 support sortMissingFirst but not yet in 3.x
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2881) Trie fields should support
sortMissingLast="true"
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148850#comment-13148850 ]
Uwe Schindler commented on SOLR-2881:
-------------------------------------
Erick: Do you have a patch? I have seen your insanity report on IRC but was not able to reproduce without a patch. The insanity reported at [http://colabti.org/irclogger/irclogger_log/lucene-dev?date=2011-11-11#l208] looks correct (and should be allowed), but maybe there is something else still using the StringIndex cache.
> Trie fields should support sortMissingLast="true"
> -------------------------------------------------
>
> Key: SOLR-2881
> URL: https://issues.apache.org/jira/browse/SOLR-2881
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
> Affects Versions: 3.5, 4.0
> Environment: All
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Fix For: 3.5, 4.0
>
>
> Spinoff from SOLR-2134. The consensus is that the way sortMissingFirst is done in 3x is superior to 4x and when that is done (see LUCENE-3443) then the sortMissingFirst code should be incorporated into both.
> As of now, however, the Trie fields in 4.0 support sortMissingFirst but not yet in 3.x
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2881) Trie fields should support
sortMissingLast="true"
Posted by "Erick Erickson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149100#comment-13149100 ]
Erick Erickson commented on SOLR-2881:
--------------------------------------
Uwe:
Mike e-mailed me with a possibility and it looks like he nailed it. We'll coordinate what to do next, but it looks like we'll get it fixed up.
I should be able to put up a patch later this evening (EST), will that do?
> Trie fields should support sortMissingLast="true"
> -------------------------------------------------
>
> Key: SOLR-2881
> URL: https://issues.apache.org/jira/browse/SOLR-2881
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
> Affects Versions: 3.5, 4.0
> Environment: All
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Fix For: 3.5, 4.0
>
>
> Spinoff from SOLR-2134. The consensus is that the way sortMissingFirst is done in 3x is superior to 4x and when that is done (see LUCENE-3443) then the sortMissingFirst code should be incorporated into both.
> As of now, however, the Trie fields in 4.0 support sortMissingFirst but not yet in 3.x
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org