[GitHub] [spark] sarthfrey-db commented on a change in pull request #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext

[GitBox <gi...@apache.org>]

sarthfrey-db commented on a change in pull request #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext
URL: https://github.com/apache/spark/pull/27395#discussion_r373752250
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/BarrierCoordinator.scala
 ##########
 @@ -225,10 +262,19 @@ private[spark] sealed trait BarrierCoordinatorMessage extends Serializable
  * @param stageAttemptId ID of current stage attempt
  * @param taskAttemptId Unique ID of current task
  * @param barrierEpoch ID of the `barrier()` call, a task may consist multiple `barrier()` calls.
+ * @param requestMethod The BarrierTaskContext method that was called to trigger BarrierCoordinator
+ * @param allGatherMessage Message sent from the BarrierTaskContext if requestMethod is ALL_GATHER
  */
 private[spark] case class RequestToSync(
     numTasks: Int,
     stageId: Int,
     stageAttemptId: Int,
     taskAttemptId: Long,
-    barrierEpoch: Int) extends BarrierCoordinatorMessage
+    barrierEpoch: Int,
 
 Review comment:
   I see, though it is only 1 parameter - do you think the complexity introduced in the request checking is worth the verbosity?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org