You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/01/24 13:33:40 UTC
[PR] change pom name [incubator-pekko-grpc]
pjfanning opened a new pull request, #216:
URL: https://github.com/apache/incubator-pekko-grpc/pull/216
use `gRPC` to match the usual style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] change pom name [incubator-pekko-grpc]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #216:
URL: https://github.com/apache/incubator-pekko-grpc/pull/216#discussion_r1464936101
##########
gradle-plugin/build.gradle:
##########
@@ -47,7 +47,7 @@ gradlePlugin {
publishing {
publications.withType(MavenPublication) {
pom {
- name = "Apache Pekko Grpc Gradle Plugin"
+ name = "Apache Pekko gRPC Gradle Plugin"
Review Comment:
the text below is `gRPC`, so I +1 for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] change pom name [incubator-pekko-grpc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #216:
URL: https://github.com/apache/incubator-pekko-grpc/pull/216#issuecomment-1909934882
@pjfanning You want to merge this or you still waiting on something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] change pom name [incubator-pekko-grpc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #216:
URL: https://github.com/apache/incubator-pekko-grpc/pull/216#issuecomment-1908164307
> I understand that we don't want to complicate the sbt plugin to cover the case issue but there is no absolute requirement that this gradle-plugin pom needs to match the other poms.
You can easily add it in this project, just do
```scala
ThisBuild / apacheSonatypeArtifactNameProcessor := { artifactId =>
val prettified = artifactId
.replaceAll("-", " ")
.replaceAll("_", " ")
.split(" ")
.map(_.capitalize)
.replaceAll("Grpc","gRPC")
.mkString(" ")
if (prettified.startsWith("Apache ")) prettified else s"Apache $prettified"
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] change pom name [incubator-pekko-grpc]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #216:
URL: https://github.com/apache/incubator-pekko-grpc/pull/216#discussion_r1465630528
##########
build.sbt:
##########
@@ -32,6 +32,11 @@ commands := commands.value.filterNot { command =>
ThisBuild / reproducibleBuildsCheckResolver := Resolver.ApacheMavenStagingRepo
+// So that gRPC is properly styled
+ThisBuild / apacheSonatypeArtifactNameProcessor := apacheSonatypeArtifactNameProcessor.value.andThen {
+ _.replaceAll("Grpc", "gRPC")
Review Comment:
Looks great, but better if it match something like GRPC too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] change pom name [incubator-pekko-grpc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #216:
URL: https://github.com/apache/incubator-pekko-grpc/pull/216#issuecomment-1908156664
I understand that we don't want to complicate the sbt plugin to cover the case issue but there is no absolute requirement that this gradle-plugin pom needs to match the other poms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] change pom name [incubator-pekko-grpc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #216:
URL: https://github.com/apache/incubator-pekko-grpc/pull/216#issuecomment-1909942941
merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] change pom name [incubator-pekko-grpc]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #216:
URL: https://github.com/apache/incubator-pekko-grpc/pull/216#discussion_r1464943362
##########
gradle-plugin/build.gradle:
##########
@@ -47,7 +47,7 @@ gradlePlugin {
publishing {
publications.withType(MavenPublication) {
pom {
- name = "Apache Pekko Grpc Gradle Plugin"
+ name = "Apache Pekko gRPC Gradle Plugin"
Review Comment:
and the Logo is GRPC :)! maybe it's fine. will this name cause any trademark issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] change pom name [incubator-pekko-grpc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #216:
URL: https://github.com/apache/incubator-pekko-grpc/pull/216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] change pom name [incubator-pekko-grpc]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #216:
URL: https://github.com/apache/incubator-pekko-grpc/pull/216#discussion_r1464944675
##########
gradle-plugin/build.gradle:
##########
@@ -47,7 +47,7 @@ gradlePlugin {
publishing {
publications.withType(MavenPublication) {
pom {
- name = "Apache Pekko Grpc Gradle Plugin"
+ name = "Apache Pekko gRPC Gradle Plugin"
Review Comment:
and it was `"pekko-grpc-gradle-plugin"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] change pom name [incubator-pekko-grpc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #216:
URL: https://github.com/apache/incubator-pekko-grpc/pull/216#discussion_r1465632686
##########
build.sbt:
##########
@@ -32,6 +32,11 @@ commands := commands.value.filterNot { command =>
ThisBuild / reproducibleBuildsCheckResolver := Resolver.ApacheMavenStagingRepo
+// So that gRPC is properly styled
+ThisBuild / apacheSonatypeArtifactNameProcessor := apacheSonatypeArtifactNameProcessor.value.andThen {
+ _.replaceAll("Grpc", "gRPC")
Review Comment:
the built plugin title cases the name - so Grpc is what is expected - making ths case insensitive is complicated and not worth the hassle
##########
build.sbt:
##########
@@ -32,6 +32,11 @@ commands := commands.value.filterNot { command =>
ThisBuild / reproducibleBuildsCheckResolver := Resolver.ApacheMavenStagingRepo
+// So that gRPC is properly styled
+ThisBuild / apacheSonatypeArtifactNameProcessor := apacheSonatypeArtifactNameProcessor.value.andThen {
+ _.replaceAll("Grpc", "gRPC")
Review Comment:
the built plugin title cases the name - so Grpc is what is expected - making this case insensitive is complicated and not worth the hassle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org