You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/10/27 07:21:00 UTC
[GitHub] [iotdb] THUMarkLau opened a new pull request #4240: Compatible with compaction recovery in 0.12
THUMarkLau opened a new pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240
In 0.12, compaction log is store in system_dir/storage_group. In new compaction, compaction log is store in data directory. To compatible with the old compaction recovery, this pr will search compaction log in system dir.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4240: Compatible with compaction recovery in 0.12
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#issuecomment-952650744
[](https://coveralls.io/builds/43890388)
Coverage decreased (-0.02%) to 66.905% when pulling **07199c73f99d9007e7784adf1a6624043fcd6372 on THUMarkLau:new_compaction** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a change in pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#discussion_r741059529
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/inner/sizetiered/SizeTieredCompactionRecoverTask.java
##########
@@ -121,11 +163,19 @@ public void doCompaction() {
} catch (IOException e) {
LOGGER.error("recover inner space compaction error", e);
} finally {
+ ChunkCache.getInstance().clear();
+ TimeSeriesMetadataCache.getInstance().clear();
Review comment:
This is not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#issuecomment-958611491
Hi, you can merge the master branch to fix the CI now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#issuecomment-952650744
[](https://coveralls.io/builds/43970915)
Coverage increased (+0.005%) to 66.965% when pulling **9d7badaa676c8c10175e574577dbf58dbdee94ab on THUMarkLau:new_compaction** into **b05e21c078debcbb020d62ecd6d8a00a932863bd on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#issuecomment-952650744
[](https://coveralls.io/builds/43971283)
Coverage increased (+0.01%) to 66.97% when pulling **9d7badaa676c8c10175e574577dbf58dbdee94ab on THUMarkLau:new_compaction** into **b05e21c078debcbb020d62ecd6d8a00a932863bd on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4240: Compatible with compaction recovery in 0.12
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#issuecomment-952650744
[](https://coveralls.io/builds/43914928)
Coverage decreased (-0.03%) to 66.89% when pulling **f34277f7ee4e5f2bd230f1789d7d5605623fd662 on THUMarkLau:new_compaction** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] THUMarkLau commented on a change in pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
THUMarkLau commented on a change in pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#discussion_r741582157
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/inner/sizetiered/SizeTieredCompactionRecoverTask.java
##########
@@ -121,11 +163,19 @@ public void doCompaction() {
} catch (IOException e) {
LOGGER.error("recover inner space compaction error", e);
} finally {
+ ChunkCache.getInstance().clear();
+ TimeSeriesMetadataCache.getInstance().clear();
Review comment:
resolve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#issuecomment-958611491
Hi, you can merge the master branch to fix the CI now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#issuecomment-952650744
[](https://coveralls.io/builds/43971353)
Coverage decreased (-0.006%) to 66.954% when pulling **9d7badaa676c8c10175e574577dbf58dbdee94ab on THUMarkLau:new_compaction** into **b05e21c078debcbb020d62ecd6d8a00a932863bd on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] THUMarkLau commented on a change in pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
THUMarkLau commented on a change in pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#discussion_r741582157
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/inner/sizetiered/SizeTieredCompactionRecoverTask.java
##########
@@ -121,11 +163,19 @@ public void doCompaction() {
} catch (IOException e) {
LOGGER.error("recover inner space compaction error", e);
} finally {
+ ChunkCache.getInstance().clear();
+ TimeSeriesMetadataCache.getInstance().clear();
Review comment:
resolve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#issuecomment-952650744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#issuecomment-952650744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#issuecomment-958611491
Hi, you can merge the master branch to fix the CI now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] THUMarkLau commented on a change in pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
THUMarkLau commented on a change in pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#discussion_r741582157
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/inner/sizetiered/SizeTieredCompactionRecoverTask.java
##########
@@ -121,11 +163,19 @@ public void doCompaction() {
} catch (IOException e) {
LOGGER.error("recover inner space compaction error", e);
} finally {
+ ChunkCache.getInstance().clear();
+ TimeSeriesMetadataCache.getInstance().clear();
Review comment:
resolve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4240: Compatible with compaction recovery in 0.12
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#issuecomment-952650744
[](https://coveralls.io/builds/43833869)
Coverage increased (+0.09%) to 67.011% when pulling **db26228d64fb5700f8af23b8c8b0cb2491bb4213 on THUMarkLau:new_compaction** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#issuecomment-952650744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#issuecomment-952650744
[](https://coveralls.io/builds/43970973)
Coverage increased (+0.1%) to 67.073% when pulling **9d7badaa676c8c10175e574577dbf58dbdee94ab on THUMarkLau:new_compaction** into **b05e21c078debcbb020d62ecd6d8a00a932863bd on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#issuecomment-958611491
Hi, you can merge the master branch to fix the CI now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #4240: Compatible with compaction recovery in 0.12
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#issuecomment-952650744
[](https://coveralls.io/builds/43803054)
Coverage increased (+0.1%) to 67.065% when pulling **9f1a945421a13915690ddd1b3a29cf33aa0066e0 on THUMarkLau:new_compaction** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4240: Compatible with compaction recovery in 0.12
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#issuecomment-952650744
[](https://coveralls.io/builds/43836241)
Coverage decreased (-0.03%) to 66.888% when pulling **d7eb0d61648a11dcd930931976544ead46ad580b on THUMarkLau:new_compaction** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a change in pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#discussion_r741059529
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/inner/sizetiered/SizeTieredCompactionRecoverTask.java
##########
@@ -121,11 +163,19 @@ public void doCompaction() {
} catch (IOException e) {
LOGGER.error("recover inner space compaction error", e);
} finally {
+ ChunkCache.getInstance().clear();
+ TimeSeriesMetadataCache.getInstance().clear();
Review comment:
This is not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a change in pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#discussion_r741059529
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/inner/sizetiered/SizeTieredCompactionRecoverTask.java
##########
@@ -121,11 +163,19 @@ public void doCompaction() {
} catch (IOException e) {
LOGGER.error("recover inner space compaction error", e);
} finally {
+ ChunkCache.getInstance().clear();
+ TimeSeriesMetadataCache.getInstance().clear();
Review comment:
This is not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] THUMarkLau commented on a change in pull request #4240: [IOTDB-1604] Fix data increase when shut down iotdb in 0.12 and restart iotdb-0.13
Posted by GitBox <gi...@apache.org>.
THUMarkLau commented on a change in pull request #4240:
URL: https://github.com/apache/iotdb/pull/4240#discussion_r741582157
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/inner/sizetiered/SizeTieredCompactionRecoverTask.java
##########
@@ -121,11 +163,19 @@ public void doCompaction() {
} catch (IOException e) {
LOGGER.error("recover inner space compaction error", e);
} finally {
+ ChunkCache.getInstance().clear();
+ TimeSeriesMetadataCache.getInstance().clear();
Review comment:
resolve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org