[GitHub] [spark] dchvn commented on a change in pull request #34673: [WIP][SPARK-37343][SQL] Implement createIndex, IndexExists and dropIndex in JDBC (Postgres dialect)

[GitBox <gi...@apache.org>]

dchvn commented on a change in pull request #34673:
URL: https://github.com/apache/spark/pull/34673#discussion_r753636069



##########
File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala
##########
@@ -193,6 +193,8 @@ private[v2] trait V2JDBCTest extends SharedSparkSession with DockerIntegrationFu
 
   test("SPARK-36895: Test INDEX Using SQL") {
     if (supportsIndex) {
+      val indexOptions = if (catalogName.equals("mysql")) "KEY_BLOCK_SIZE=10"
+        else if (catalogName.equals("postgresql")) "FILLFACTOR=70"

Review comment:
       Depend on type of jdbc dialect, we change the index options for test.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org