You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "wangxianghu (Jira)" <ji...@apache.org> on 2020/08/21 01:44:00 UTC

[jira] [Comment Edited] (HUDI-1207) Move kafka implemetation of write commit callback to hudi-client module

    [ https://issues.apache.org/jira/browse/HUDI-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181520#comment-17181520 ] 

wangxianghu edited comment on HUDI-1207 at 8/21/20, 1:43 AM:
-------------------------------------------------------------

Hi, [~vinoth] as discussed before,  put Kafka callback in hudi-client module would be more uniform and elegant, so I filed this ticket.

Core modules(like {{hudi-client}} and {{hudi-spark}}) taking a direct dependency on application dependencies(like Kafka) will make the core package more and more bloated, this is indeed a problem. 

As for this case, maybe we can make kafka related denpendencies scope to "provided", if user really want to use kafka callback,  they can add kafka dependency by themselves(via --jars). 

WDYT?


was (Author: wangxianghu):
Hi, [~vinoth] as discussed before,  put Kafka callback in hudi-client module would be more uniform and elegant, so I filed this ticket.

Since you don't  want {{hudi-client}} or {{hudi-spark}} talking a direct dependency on kafka, maybe we can make kafka related denpendencies scope to "provided", if user really want to use kafka callback,  they can add kafka dependency by themselves(via --jars). 

WDYT?

> Move kafka implemetation of write commit callback  to hudi-client module
> ------------------------------------------------------------------------
>
>                 Key: HUDI-1207
>                 URL: https://issues.apache.org/jira/browse/HUDI-1207
>             Project: Apache Hudi
>          Issue Type: Task
>            Reporter: wangxianghu
>            Assignee: wangxianghu
>            Priority: Major
>             Fix For: 0.6.1
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)