You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2012/07/18 18:08:16 UTC

svn commit: r1362996 - in /commons/proper/logging/trunk: RELEASE-NOTES.txt src/java/org/apache/commons/logging/impl/LogFactoryImpl.java

Author: sebb
Date: Wed Jul 18 16:08:15 2012
New Revision: 1362996

URL: http://svn.apache.org/viewvc?rev=1362996&view=rev
Log:
LOGGING-145 - LogFactoryImpl.setAttribute - possible NPE

Modified:
    commons/proper/logging/trunk/RELEASE-NOTES.txt
    commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/LogFactoryImpl.java

Modified: commons/proper/logging/trunk/RELEASE-NOTES.txt
URL: http://svn.apache.org/viewvc/commons/proper/logging/trunk/RELEASE-NOTES.txt?rev=1362996&r1=1362995&r2=1362996&view=diff
==============================================================================
--- commons/proper/logging/trunk/RELEASE-NOTES.txt (original)
+++ commons/proper/logging/trunk/RELEASE-NOTES.txt Wed Jul 18 16:08:15 2012
@@ -19,6 +19,7 @@
 
 TODO - rework notes to incorporate: Changes since 1.1.1
 LOGGING-130 - Potential missing privileged block for class loader
+LOGGING-145 - LogFactoryImpl.setAttribute - possible NPE
 
 $Id$
 

Modified: commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/LogFactoryImpl.java
URL: http://svn.apache.org/viewvc/commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/LogFactoryImpl.java?rev=1362996&r1=1362995&r2=1362996&view=diff
==============================================================================
--- commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/LogFactoryImpl.java (original)
+++ commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/LogFactoryImpl.java Wed Jul 18 16:08:15 2012
@@ -406,7 +406,7 @@ public class LogFactoryImpl extends LogF
         }
         
         if (name.equals(TCCL_KEY)) {
-            useTCCL = Boolean.valueOf(value.toString()).booleanValue();
+            useTCCL = value != null && Boolean.valueOf(value.toString()).booleanValue();
         }
 
     }