You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/05 15:49:27 UTC

[GitHub] [airflow] ashb opened a new issue, #26164: Status of testing Providers that were prepared on September 05, 2022

ashb opened a new issue, #26164:
URL: https://github.com/apache/airflow/issues/26164

   ### Body
   
   I have a kind request for all the contributors to the latest provider packages release.
   Could you please help us to test the RC versions of the providers?
   
   Let us know in the comment, whether the issue is addressed.
   
   Those are providers that require testing as there were some substantial changes introduced:
   
   
   ## Provider [amazon: 5.1.0rc1](https://pypi.org/project/apache-airflow-providers-amazon/5.1.0rc1)
      - [ ] [Additional mask AWS Credentials (#26014)](https://github.com/apache/airflow/pull/26014): @Taragolis
      - [ ] [Add RedshiftDeleteClusterSnapshotOperator (#25975)](https://github.com/apache/airflow/pull/25975): @pankajastro
      - [ ] [Add redshift create cluster snapshot operator (#25857)](https://github.com/apache/airflow/pull/25857): @pankajastro
      - [ ] [Add common-sql lower bound for common-sql (#25789)](https://github.com/apache/airflow/pull/25789): @potiuk
      - [ ] [Allow AWS Secrets Backends use AWS Connection capabilities (#25628)](https://github.com/apache/airflow/pull/25628): @Taragolis
      - [ ] [Implement `EmrEksCreateClusterOperator` (#25816)](https://github.com/apache/airflow/pull/25816): @phanikumv
      - [ ] [Improve error handling/messaging around bucket exist check (#25805)](https://github.com/apache/airflow/pull/25805): @o-nikolas
      - [ ] [Fix display aws connection info (#26025)](https://github.com/apache/airflow/pull/26025): @Taragolis
      - [ ] [Fix `EcsBaseOperator` and `EcsBaseSensor` arguments (#25989)](https://github.com/apache/airflow/pull/25989): @Taragolis
      - [ ] [Fix RDS system test (#25839)](https://github.com/apache/airflow/pull/25839): @vincbeck
      - [ ] [Avoid circular import problems when instantiating AWS SM backend (#25810)](https://github.com/apache/airflow/pull/25810): @Taragolis
      - [ ] [Fix construction of Connection object in version Amazon provider 5.0.0rc3 (#25716)](https://github.com/apache/airflow/pull/25716): @dwreeves
   ## Provider [common.sql: 1.2.0rc1](https://pypi.org/project/apache-airflow-providers-common-sql/1.2.0rc1)
      - [ ] [Fix placeholders in `TrinoHook`, `PrestoHook`, `SqliteHook` (#25939)](https://github.com/apache/airflow/pull/25939): @alexandermalyga
      - [ ] [Better error messsage for pre-common-sql providers (#26051)](https://github.com/apache/airflow/pull/26051): @potiuk
      - [ ] [Fix (and test) SQLTableCheckOperator on postgresql (#25821)](https://github.com/apache/airflow/pull/25821): @ashb
      - [ ] [Don&#39;t use Pandas for SQLTableCheckOperator (#25822)](https://github.com/apache/airflow/pull/25822): @ashb
      - [ ] [Discard semicolon stripping in SQL hook (#25855)](https://github.com/apache/airflow/pull/25855): @kazanzhy
   ## Provider [postgres: 5.2.1rc1](https://pypi.org/project/apache-airflow-providers-postgres/5.2.1rc1)
      - [ ] [Bump dep on common-sql to fix issue with SQLTableCheckOperator (#26143)](https://github.com/apache/airflow/pull/26143): @ashb
   ## Provider [presto: 4.0.1rc1](https://pypi.org/project/apache-airflow-providers-presto/4.0.1rc1)
      - [ ] [Add common-sql lower bound for common-sql (#25789)](https://github.com/apache/airflow/pull/25789): @potiuk
      - [ ] [Fix placeholders in `TrinoHook`, `PrestoHook`, `SqliteHook` (#25939)](https://github.com/apache/airflow/pull/25939): @alexandermalyga
   ## Provider [sqlite: 3.2.1rc1](https://pypi.org/project/apache-airflow-providers-sqlite/3.2.1rc1)
      - [ ] [Add common-sql lower bound for common-sql (#25789)](https://github.com/apache/airflow/pull/25789): @potiuk
      - [ ] [Fix placeholders in `TrinoHook`, `PrestoHook`, `SqliteHook` (#25939)](https://github.com/apache/airflow/pull/25939): @alexandermalyga
   ## Provider [trino: 4.0.1rc1](https://pypi.org/project/apache-airflow-providers-trino/4.0.1rc1)
      - [ ] [Add common-sql lower bound for common-sql (#25789)](https://github.com/apache/airflow/pull/25789): @potiuk
      - [ ] [Fix placeholders in `TrinoHook`, `PrestoHook`, `SqliteHook` (#25939)](https://github.com/apache/airflow/pull/25939): @alexandermalyga
   
   The guidelines on how to test providers can be found in
   
   [Verify providers by contributors](https://github.com/apache/airflow/blob/main/dev/README_RELEASE_PROVIDER_PACKAGES.md#verify-by-contributors)
   
   All users involved in the PRs:
   @pankajastro @potiuk @dwreeves @Taragolis @vincbeck @kazanzhy @ashb @phanikumv @o-nikolas @alexandermalyga
   
   
   ### Committer
   
   - [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] dwreeves commented on issue #26164: Status of testing Providers that were prepared on September 05, 2022

Posted by GitBox <gi...@apache.org>.
dwreeves commented on issue #26164:
URL: https://github.com/apache/airflow/issues/26164#issuecomment-1237607699

   (Yeah sorry I wasn't clear with how I phrased that. "It made its way in" <-- "it" meaning the bug, not the fix for said bug.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #26164: Status of testing Providers that were prepared on September 05, 2022

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #26164:
URL: https://github.com/apache/airflow/issues/26164#issuecomment-1237425456

   @ashb @dwreeves  - the change is properly included in the Changelog for 5.1.0:
   
   * ``fix bug construction of Connection object in version 5.0.0rc3 (#25716)``
   
   So I think what @dwreeves asks is to cick "OK" as "tested" - though it would be nice if you could test it yourselves @dwreeves  :)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kazanzhy commented on issue #26164: Status of testing Providers that were prepared on September 05, 2022

Posted by GitBox <gi...@apache.org>.
kazanzhy commented on issue #26164:
URL: https://github.com/apache/airflow/issues/26164#issuecomment-1237473702

   Checked https://github.com/apache/airflow/pull/25855 with PostgresHook. Seems ok.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb closed issue #26164: Status of testing Providers that were prepared on September 05, 2022

Posted by GitBox <gi...@apache.org>.
ashb closed issue #26164: Status of testing Providers that were prepared on September 05, 2022
URL: https://github.com/apache/airflow/issues/26164


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #26164: Status of testing Providers that were prepared on September 05, 2022

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #26164:
URL: https://github.com/apache/airflow/issues/26164#issuecomment-1237426708

   Common.sql lower-bounds are updated for those providers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on issue #26164: Status of testing Providers that were prepared on September 05, 2022

Posted by GitBox <gi...@apache.org>.
ashb commented on issue #26164:
URL: https://github.com/apache/airflow/issues/26164#issuecomment-1237337052

   @dwreeves thanks - the list was auto generated. Was your change in 5.0.0 of the provider do you know?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #26164: Status of testing Providers that were prepared on September 05, 2022

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #26164:
URL: https://github.com/apache/airflow/issues/26164#issuecomment-1237423735

   > @dwreeves thanks - the list was auto generated. Was your change in 5.0.0 of the provider do you know?
   
   I dont think it was.
   Amazon provider 5.0.0 was releases on 14-Aug
   https://github.com/apache/airflow/pull/25716 was merged on 15-Aug
   The code with the amazon provider 5.0.0 tag doesnt have the changes in the PR:
   
   https://github.com/apache/airflow/blob/5923788143e7871b56de5164b96a407b2fba75b8/airflow/providers/amazon/aws/secrets/secrets_manager.py#L200
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] phanikumv commented on issue #26164: Status of testing Providers that were prepared on September 05, 2022

Posted by GitBox <gi...@apache.org>.
phanikumv commented on issue #26164:
URL: https://github.com/apache/airflow/issues/26164#issuecomment-1237980068

   Tested https://github.com/apache/airflow/pull/25816 , it is working good.
   
   <img width="1702" alt="image" src="https://user-images.githubusercontent.com/94376113/188615406-2e07f6f3-045f-4629-a8c9-31c839b4aa3a.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] dwreeves commented on issue #26164: Status of testing Providers that were prepared on September 05, 2022

Posted by GitBox <gi...@apache.org>.
dwreeves commented on issue #26164:
URL: https://github.com/apache/airflow/issues/26164#issuecomment-1237252388

   My PR #25716 came about from testing for the Amazon provider package `5.0.0` and is a very simple 1-line change. (It was a PR for fixing a minor bug in `5.0.0rc3` from when I was testing that.) It does seem like it unfortunately made its way into the `5.0.0` release, hence why it's part of the `5.1.0` release cycle.
   
   <img width="556" alt="image" src="https://user-images.githubusercontent.com/31971762/188485403-72ce9a83-d7ec-4c54-a13d-f3b4a2abdbc7.png">
   
   Previous issue when my testing uncovered it: https://github.com/apache/airflow/issues/25640#issuecomment-1214247486
   
   So I think you can ✔️ me?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] alexandermalyga commented on issue #26164: Status of testing Providers that were prepared on September 05, 2022

Posted by GitBox <gi...@apache.org>.
alexandermalyga commented on issue #26164:
URL: https://github.com/apache/airflow/issues/26164#issuecomment-1240784168

   Tested #25939 with Trino, Presto and SQLite hooks. The issue has been solved and it works like expected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on issue #26164: Status of testing Providers that were prepared on September 05, 2022

Posted by GitBox <gi...@apache.org>.
ashb commented on issue #26164:
URL: https://github.com/apache/airflow/issues/26164#issuecomment-1240899023

   Releasing now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #26164: Status of testing Providers that were prepared on September 05, 2022

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #26164:
URL: https://github.com/apache/airflow/issues/26164#issuecomment-1237983200

   > Tested #25816 , it is working good.
   
   What an interesting set of colours. I wonder if they mean something :) 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] Taragolis commented on issue #26164: Status of testing Providers that were prepared on September 05, 2022

Posted by GitBox <gi...@apache.org>.
Taragolis commented on issue #26164:
URL: https://github.com/apache/airflow/issues/26164#issuecomment-1237387287

   #25810 - No more circular import issue
   #25989, #26014, #26025 - Work as expected


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] pankajastro commented on issue #26164: Status of testing Providers that were prepared on September 05, 2022

Posted by GitBox <gi...@apache.org>.
pankajastro commented on issue #26164:
URL: https://github.com/apache/airflow/issues/26164#issuecomment-1239759681

   Worked as expected https://github.com/apache/airflow/pull/25857 and https://github.com/apache/airflow/pull/25975


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org