[GitHub] [druid] github-code-scanning[bot] commented on a diff in pull request #13946: Update DruidSchemaManager methods to provide SegmentMetadataCache

["github-code-scanning[bot] (via GitHub)" <gi...@apache.org>]

github-code-scanning[bot] commented on code in PR #13946:
URL: https://github.com/apache/druid/pull/13946#discussion_r1140682021


##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchemaManager.java:
##########
@@ -51,12 +51,12 @@
   @Deprecated
   Map<String, DruidTable> getTables();
 
-  default DruidTable getTable(String name)
+  default DruidTable getTable(String name, SegmentMetadataCache segmentMetadataCache)

Review Comment:
   ## Useless parameter
   
   The parameter 'segmentMetadataCache' is never used.
   
   [Show more details](https://github.com/apache/druid/security/code-scanning/4408)



##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchemaManager.java:
##########
@@ -51,12 +51,12 @@
   @Deprecated
   Map<String, DruidTable> getTables();
 
-  default DruidTable getTable(String name)
+  default DruidTable getTable(String name, SegmentMetadataCache segmentMetadataCache)
   {
     return getTables().get(name);
   }
 
-  default Set<String> getTableNames()
+  default Set<String> getTableNames(SegmentMetadataCache segmentMetadataCache)

Review Comment:
   ## Useless parameter
   
   The parameter 'segmentMetadataCache' is never used.
   
   [Show more details](https://github.com/apache/druid/security/code-scanning/4407)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org