You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2007/12/05 00:54:43 UTC
[jira] Created: (HADOOP-2349) FSEditLog.logEdit(byte op, Writable
w1, Writable w2) should accept variable numbers of Writable, instead of
two.
FSEditLog.logEdit(byte op, Writable w1, Writable w2) should accept variable numbers of Writable, instead of two.
----------------------------------------------------------------------------------------------------------------
Key: HADOOP-2349
URL: https://issues.apache.org/jira/browse/HADOOP-2349
Project: Hadoop
Issue Type: Improvement
Reporter: Tsz Wo (Nicholas), SZE
Priority: Minor
The new declaration should be
{code}
FSEditLog.logEdit(byte op, Writable ... w)
{code}
All Writable parameters should not be null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2349) FSEditLog.logEdit(byte op, Writable
w1, Writable w2) should accept variable numbers of Writable, instead of
two.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-2349:
-------------------------------------------
Status: Patch Available (was: Open)
> FSEditLog.logEdit(byte op, Writable w1, Writable w2) should accept variable numbers of Writable, instead of two.
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2349
> URL: https://issues.apache.org/jira/browse/HADOOP-2349
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: 2349_20071204.patch
>
>
> The new declaration should be
> {code}
> FSEditLog.logEdit(byte op, Writable ... w)
> {code}
> All Writable parameters should not be null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2349) FSEditLog.logEdit(byte op, Writable
w1, Writable w2) should accept variable numbers of Writable, instead of
two.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-2349:
-------------------------------------------
Component/s: dfs
Assignee: Tsz Wo (Nicholas), SZE
> FSEditLog.logEdit(byte op, Writable w1, Writable w2) should accept variable numbers of Writable, instead of two.
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2349
> URL: https://issues.apache.org/jira/browse/HADOOP-2349
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
>
> The new declaration should be
> {code}
> FSEditLog.logEdit(byte op, Writable ... w)
> {code}
> All Writable parameters should not be null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2349) FSEditLog.logEdit(byte op, Writable
w1, Writable w2) should accept variable numbers of Writable, instead of
two.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548607 ]
Hadoop QA commented on HADOOP-2349:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12370983/2349_20071204.patch
against trunk revision r601232.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new compiler warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests -1. The patch failed contrib unit tests.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1268/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1268/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1268/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1268/console
This message is automatically generated.
> FSEditLog.logEdit(byte op, Writable w1, Writable w2) should accept variable numbers of Writable, instead of two.
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2349
> URL: https://issues.apache.org/jira/browse/HADOOP-2349
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: 2349_20071204.patch
>
>
> The new declaration should be
> {code}
> FSEditLog.logEdit(byte op, Writable ... w)
> {code}
> All Writable parameters should not be null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2349) FSEditLog.logEdit(byte op, Writable
w1, Writable w2) should accept variable numbers of Writable, instead of
two.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-2349:
-------------------------------------------
Attachment: 2349_20071204.patch
2349_20071204.patch provides the improvement.
> FSEditLog.logEdit(byte op, Writable w1, Writable w2) should accept variable numbers of Writable, instead of two.
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2349
> URL: https://issues.apache.org/jira/browse/HADOOP-2349
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: 2349_20071204.patch
>
>
> The new declaration should be
> {code}
> FSEditLog.logEdit(byte op, Writable ... w)
> {code}
> All Writable parameters should not be null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2349) FSEditLog.logEdit(byte op, Writable
w1, Writable w2) should accept variable numbers of Writable, instead of
two.
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548472 ]
dhruba borthakur commented on HADOOP-2349:
------------------------------------------
+1. Code looks good.
> FSEditLog.logEdit(byte op, Writable w1, Writable w2) should accept variable numbers of Writable, instead of two.
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2349
> URL: https://issues.apache.org/jira/browse/HADOOP-2349
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: 2349_20071204.patch
>
>
> The new declaration should be
> {code}
> FSEditLog.logEdit(byte op, Writable ... w)
> {code}
> All Writable parameters should not be null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2349) FSEditLog.logEdit(byte op, Writable
w1, Writable w2) should accept variable numbers of Writable, instead of
two.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549009 ]
Hudson commented on HADOOP-2349:
--------------------------------
Integrated in Hadoop-Nightly #324 (See [http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/324/])
> FSEditLog.logEdit(byte op, Writable w1, Writable w2) should accept variable numbers of Writable, instead of two.
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2349
> URL: https://issues.apache.org/jira/browse/HADOOP-2349
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: 2349_20071204.patch
>
>
> The new declaration should be
> {code}
> FSEditLog.logEdit(byte op, Writable ... w)
> {code}
> All Writable parameters should not be null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2349) FSEditLog.logEdit(byte op, Writable
w1, Writable w2) should accept variable numbers of Writable, instead of
two.
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-2349:
-------------------------------------
Resolution: Fixed
Fix Version/s: 0.16.0
Status: Resolved (was: Patch Available)
I just committed this. Thanks Nicholas!
> FSEditLog.logEdit(byte op, Writable w1, Writable w2) should accept variable numbers of Writable, instead of two.
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-2349
> URL: https://issues.apache.org/jira/browse/HADOOP-2349
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: 2349_20071204.patch
>
>
> The new declaration should be
> {code}
> FSEditLog.logEdit(byte op, Writable ... w)
> {code}
> All Writable parameters should not be null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.