[GitHub] [couchdb] big-r81 commented on a diff in pull request #4041: Allow and evaluate nested json claim roles

[GitBox <gi...@apache.org>]

big-r81 commented on code in PR #4041:
URL: https://github.com/apache/couchdb/pull/4041#discussion_r899970375


##########
test/elixir/test/jwt_roles_claim_test.exs:
##########
@@ -0,0 +1,126 @@
+defmodule JwtRolesClaimTest do
+  use CouchTestCase
+
+  @testdb "jwttestdb"
+
+  @global_server_config [
+    %{
+      :section => "chttpd",
+      :key => "authentication_handlers",
+      :value => [
+                  "{chttpd_auth, jwt_authentication_handler}, ",
+                  "{chttpd_auth, cookie_authentication_handler}, ",
+                  "{chttpd_auth, default_authentication_handler})"
+                ] |> Enum.join
+    },
+    %{
+      :section => "jwt_keys",
+      :key => "hmac:myjwttestkey",
+      :value => ~w(
+        NTNv7j0TuYARvmNMmWXo6fKvM4o6nv/aUi9ryX38ZH+L1bkrnD1ObOQ8JAUmHCBq7
+        Iy7otZcyAagBLHVKvvYaIpmMuxmARQ97jUVG16Jkpkp1wXOPsrF9zwew6TpczyH
+        kHgX5EuLg2MeBuiT/qJACs1J0apruOOJCg/gOtkjB4c=) |> Enum.join()
+    }
+  ]
+
+  setup do

Review Comment:
   Hi, oh yes, we dont' need it! Good catch! First I wanted to evaluate `$db/_security` and found the way to the `_session` endpoint. So I can remove setup/0 and tear_down/0.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org