You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Attila Jeges (Code Review)" <ge...@cloudera.org> on 2021/07/23 10:25:54 UTC

[Impala-ASF-CR] IMPALA-10820: Fix calculating default block size for parquest files 

Attila Jeges has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17719


Change subject: IMPALA-10820: Fix calculating default block size for parquest files
......................................................................

IMPALA-10820: Fix calculating default block size for parquest files

This patch fixes a bug introduced in IMPALA-10627. Because of the bug
the wrong default block size was used for parquet files which broke
TestInsertWideTable.test_insert_wide_table e2e test.

Testing:
- Run test_insert_wide_table with exhaustive strategy.

Change-Id: Iac8c6dd80dfe84cb7b3d2106713eae87ce923934
---
M be/src/exec/parquet/hdfs-parquet-table-writer.cc
M be/src/exec/parquet/hdfs-parquet-table-writer.h
2 files changed, 8 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/17719/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac8c6dd80dfe84cb7b3d2106713eae87ce923934
Gerrit-Change-Number: 17719
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Jeges <at...@cloudera.com>

[Impala-ASF-CR] IMPALA-10820: Fix calculating default block size for parquest files

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17719 )

Change subject: IMPALA-10820: Fix calculating default block size for parquest files
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac8c6dd80dfe84cb7b3d2106713eae87ce923934
Gerrit-Change-Number: 17719
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Jul 2021 18:43:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10820: Fix calculating default block size for parquest files

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17719 )

Change subject: IMPALA-10820: Fix calculating default block size for parquest files
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17719/1/be/src/exec/parquet/hdfs-parquet-table-writer.h
File be/src/exec/parquet/hdfs-parquet-table-writer.h:

http://gerrit.cloudera.org:8080/#/c/17719/1/be/src/exec/parquet/hdfs-parquet-table-writer.h@171
PS1, Line 171:   void Configure(int num_cols);
nit: could you please mention 'num_cols' in the comment


http://gerrit.cloudera.org:8080/#/c/17719/1/be/src/exec/parquet/hdfs-parquet-table-writer.cc
File be/src/exec/parquet/hdfs-parquet-table-writer.cc:

http://gerrit.cloudera.org:8080/#/c/17719/1/be/src/exec/parquet/hdfs-parquet-table-writer.cc@1357
PS1, Line 1357:   columns_.resize(num_cols);
Or this could be just moved a bit upper, right?



-- 
To view, visit http://gerrit.cloudera.org:8080/17719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac8c6dd80dfe84cb7b3d2106713eae87ce923934
Gerrit-Change-Number: 17719
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Jul 2021 10:37:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10820: Fix calculating default block size for parquest files

Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17719 )

Change subject: IMPALA-10820: Fix calculating default block size for parquest files
......................................................................

IMPALA-10820: Fix calculating default block size for parquest files

This patch fixes a bug introduced in IMPALA-10627. Because of the bug
the wrong default block size was used for parquet files which broke
TestInsertWideTable.test_insert_wide_table e2e test.

Testing:
- Run test_insert_wide_table with exhaustive strategy.

Change-Id: Iac8c6dd80dfe84cb7b3d2106713eae87ce923934
---
M be/src/exec/parquet/hdfs-parquet-table-writer.cc
M be/src/exec/parquet/hdfs-parquet-table-writer.h
2 files changed, 12 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/17719/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iac8c6dd80dfe84cb7b3d2106713eae87ce923934
Gerrit-Change-Number: 17719
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10820: Fix calculating default block size for parquest files

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17719 )

Change subject: IMPALA-10820: Fix calculating default block size for parquest files
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7342/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac8c6dd80dfe84cb7b3d2106713eae87ce923934
Gerrit-Change-Number: 17719
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Jul 2021 12:30:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10820: Fix calculating default block size for parquest files

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17719 )

Change subject: IMPALA-10820: Fix calculating default block size for parquest files
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9154/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac8c6dd80dfe84cb7b3d2106713eae87ce923934
Gerrit-Change-Number: 17719
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Jul 2021 11:21:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10820: Fix calculating default block size for parquest files

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17719 )

Change subject: IMPALA-10820: Fix calculating default block size for parquest files
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9153/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac8c6dd80dfe84cb7b3d2106713eae87ce923934
Gerrit-Change-Number: 17719
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Jul 2021 10:49:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10820: Fix calculating default block size for parquest files

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17719 )

Change subject: IMPALA-10820: Fix calculating default block size for parquest files
......................................................................

IMPALA-10820: Fix calculating default block size for parquest files

This patch fixes a bug introduced in IMPALA-10627. Because of the bug
the wrong default block size was used for parquet files which broke
TestInsertWideTable.test_insert_wide_table e2e test.

Testing:
- Run test_insert_wide_table with exhaustive strategy.

Change-Id: Iac8c6dd80dfe84cb7b3d2106713eae87ce923934
Reviewed-on: http://gerrit.cloudera.org:8080/17719
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/parquet/hdfs-parquet-table-writer.cc
M be/src/exec/parquet/hdfs-parquet-table-writer.h
2 files changed, 12 insertions(+), 10 deletions(-)

Approvals:
  Zoltan Borok-Nagy: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac8c6dd80dfe84cb7b3d2106713eae87ce923934
Gerrit-Change-Number: 17719
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10820: Fix calculating default block size for parquest files

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17719 )

Change subject: IMPALA-10820: Fix calculating default block size for parquest files
......................................................................


Patch Set 2: Code-Review+2

Thanks for fixing this so quickly. LGTM!


-- 
To view, visit http://gerrit.cloudera.org:8080/17719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac8c6dd80dfe84cb7b3d2106713eae87ce923934
Gerrit-Change-Number: 17719
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Jul 2021 11:07:19 +0000
Gerrit-HasComments: No