[GitHub] [gobblin] aplex commented on a change in pull request #3382: [GOBBLIN-1527] Add finder `latestFlowGroupExecutions` to `FlowExecutions` endpoint.

[GitBox <gi...@apache.org>]

aplex commented on a change in pull request #3382:
URL: https://github.com/apache/gobblin/pull/3382#discussion_r702172501



##########
File path: gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowExecutionResourceHandler.java
##########
@@ -36,6 +36,14 @@
    */
   public List<FlowExecution> getLatestFlowExecution(PagingContext context, FlowId flowId, Integer count, String tag, String executionStatus);
 
+  /**
+   * Get latest {@link FlowExecution} for every flow in `flowGroup`
+   *
+   * NOTE: `executionStatus` param not provided yet, without justifying use case, due to complexity of interaction with `count`
+   * and resulting efficiency concern of performing across many flows sharing the single named group.
+   */
+  public List<FlowExecution> getLatestFlowGroupExecutions(PagingContext context, String flowGroup, Integer count, String tag);

Review comment:
       PagingContext already have a count and starting number. Can we use that instead of having an additional count?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org